Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: tools/viewer/sk_app/android/surface_glue_android.cpp

Issue 2003653002: Use SkASSERTResult to avoid unused local variables (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Name Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/viewer/Viewer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/viewer/sk_app/android/surface_glue_android.cpp
diff --git a/tools/viewer/sk_app/android/surface_glue_android.cpp b/tools/viewer/sk_app/android/surface_glue_android.cpp
index e8715582c096c02c3c1e0ad0b77cc90095c14150..9e35407255f8956eea8d1496692d7684886a4ede 100644
--- a/tools/viewer/sk_app/android/surface_glue_android.cpp
+++ b/tools/viewer/sk_app/android/surface_glue_android.cpp
@@ -77,13 +77,11 @@ void SkiaAndroidApp::paintIfNeeded() {
}
void SkiaAndroidApp::postMessage(const Message& message) const {
- auto writeSize = write(fPipes[1], &message, sizeof(message));
- SkASSERT(writeSize == sizeof(message));
+ SkAssertResult(write(fPipes[1], &message, sizeof(message)) == sizeof(message));
}
void SkiaAndroidApp::readMessage(Message* message) const {
- auto readSize = read(fPipes[0], message, sizeof(Message));
- SkASSERT(readSize == sizeof(Message));
+ SkAssertResult(read(fPipes[0], message, sizeof(Message)) == sizeof(Message));
egdaniel 2016/05/20 18:50:23 So just doing a fly by unsolicited review. Here wo
liyuqian 2016/05/20 18:53:00 That's a good point. However, I've already committ
}
void SkiaAndroidApp::inval() {
« no previous file with comments | « tools/viewer/Viewer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698