Handlify callers of Object::GetElement.

Handlify callers of Object::GetElement.

R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20028

[Igor Sheludko, 2014-03-17 16:50:44]

https://codereview.chromium.org/200363002/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):

https://codereview.chromium.org/200363002/diff/1/src/json-stringifier.h#newco...
src/json-stringifier.h:658: if (property.is_null()) return EXCEPTION;
RETURN_IF_EMPTY_HANDLE_VALUE(isolate_, property, EXCEPTION);

https://codereview.chromium.org/200363002/diff/1/src/liveedit.cc
File src/liveedit.cc (right):

https://codereview.chromium.org/200363002/diff/1/src/liveedit.cc#newcode1954
src/liveedit.cc:1954: if (*obj == 
Smi::FromInt(LiveEdit::FUNCTION_BLOCKED_ON_ACTIVE_STACK)) {
Extra space after ==

https://codereview.chromium.org/200363002/diff/1/src/log.cc
File src/log.cc (right):

https://codereview.chromium.org/200363002/diff/1/src/log.cc#newcode1212
src/log.cc:1212: Object::GetElement(isolate_, args_handle, format[i] - '0');
I'm afraid we can hit ASSERT(AllowHeapAllocation::IsAllowed()); inside
GetElement() in case of call from Runtime_Log().

[Yang, 2014-03-18 09:39:38]

Addressed comments.

https://codereview.chromium.org/200363002/diff/1/src/log.cc
File src/log.cc (right):

https://codereview.chromium.org/200363002/diff/1/src/log.cc#newcode1212
src/log.cc:1212: Object::GetElement(isolate_, args_handle, format[i] - '0');
On 2014/03/17 16:50:44, Igor Sheludko wrote:
> I'm afraid we can hit ASSERT(AllowHeapAllocation::IsAllowed()); inside
> GetElement() in case of call from Runtime_Log().

This will not happen, since all callers to Runtime_Log() are from string.js or
regexp.js, which pass an array literal as argument. If GetElement indeed
allocates.

In any case, I also handlified Runtime_Log().

[Igor Sheludko, 2014-03-18 10:07:07]

lgtm

[Yang, 2014-03-18 12:34:15]

Committed patchset #2 manually as r20028 (presubmit successful).