Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: src/liveedit.cc

Issue 200363002: Handlify callers of Object::GetElement. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/json-stringifier.h ('k') | src/log.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1931 matching lines...) Expand 10 before | Expand all | Expand 10 after
1942 shared_info_array->GetIsolate(), target, do_drop); 1942 shared_info_array->GetIsolate(), target, do_drop);
1943 if (message) { 1943 if (message) {
1944 return message; 1944 return message;
1945 } 1945 }
1946 1946
1947 Isolate* isolate = shared_info_array->GetIsolate(); 1947 Isolate* isolate = shared_info_array->GetIsolate();
1948 int array_len = GetArrayLength(shared_info_array); 1948 int array_len = GetArrayLength(shared_info_array);
1949 1949
1950 // Replace "blocked on active" with "replaced on active" status. 1950 // Replace "blocked on active" with "replaced on active" status.
1951 for (int i = 0; i < array_len; i++) { 1951 for (int i = 0; i < array_len; i++) {
1952 if (result->GetElement(result->GetIsolate(), i) == 1952 Handle<Object> obj = Object::GetElement(isolate, result, i);
1953 Smi::FromInt(LiveEdit::FUNCTION_BLOCKED_ON_ACTIVE_STACK)) { 1953 CHECK_NOT_EMPTY_HANDLE(isolate, obj);
1954 if (*obj == Smi::FromInt(LiveEdit::FUNCTION_BLOCKED_ON_ACTIVE_STACK)) {
1954 Handle<Object> replaced( 1955 Handle<Object> replaced(
1955 Smi::FromInt(LiveEdit::FUNCTION_REPLACED_ON_ACTIVE_STACK), isolate); 1956 Smi::FromInt(LiveEdit::FUNCTION_REPLACED_ON_ACTIVE_STACK), isolate);
1956 SetElementSloppy(result, i, replaced); 1957 SetElementSloppy(result, i, replaced);
1957 } 1958 }
1958 } 1959 }
1959 return NULL; 1960 return NULL;
1960 } 1961 }
1961 1962
1962 1963
1963 class InactiveThreadActivationsChecker : public ThreadVisitor { 1964 class InactiveThreadActivationsChecker : public ThreadVisitor {
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
2129 2130
2130 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 2131 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
2131 return false; 2132 return false;
2132 } 2133 }
2133 2134
2134 #endif // ENABLE_DEBUGGER_SUPPORT 2135 #endif // ENABLE_DEBUGGER_SUPPORT
2135 2136
2136 2137
2137 2138
2138 } } // namespace v8::internal 2139 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/json-stringifier.h ('k') | src/log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698