src/factory.cc - Issue 200363002: Handlify callers of Object::GetElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 200363002: Handlify callers of Object::GetElement. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 6f86647ef5911348cda4fa55bb590e39d4334b27..348c08965fed3f554f64ef672e02872018d08111 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1116,8 +1116,9 @@ Handle<String> Factory::EmergencyNewError(const char* message,

*p++ = ' ';

space--;

if (space > 0) {

- MaybeObject* maybe_arg = args->GetElement(isolate(), i);

- Handle<String> arg_str(reinterpret_cast<String*>(maybe_arg));

+ Handle<String> arg_str = Handle<String>::cast(

+ Object::GetElement(isolate(), args, i));

+ CHECK_NOT_EMPTY_HANDLE(isolate(), arg_str);

SmartArrayPointer<char> arg = arg_str->ToCString();

Vector<char> v2(p, static_cast<int>(space));

OS::StrNCpy(v2, arg.get(), space);

« no previous file with comments | « src/builtins.cc ('k') | src/isolate.h » ('j') | no next file with comments »