Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2003333002: cc: Task should complete as finished or canceled in tests. (Closed)

Created:
4 years, 7 months ago by prashant.n
Modified:
4 years, 7 months ago
Reviewers:
reveman, vmpstr, ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@test_task_runner
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Task should complete as finished or canceled in tests. Fixed tests which were not concluding tasks in finished or canceled state. These tests use same tasks for running them for next lap. So whereever necessary either reset the state of tasks before running next lap or cancel them after running all the laps. BUG=613814 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/1e52becffdcc78f38589a0e0cdfb0cbaa9587f2b Cr-Commit-Position: refs/heads/master@{#396274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -24 lines) Patch
M cc/raster/raster_buffer_provider_perftest.cc View 8 chunks +29 lines, -3 lines 0 comments Download
M cc/raster/task.cc View 1 chunk +1 line, -5 lines 0 comments Download
M cc/raster/task_graph_runner_perftest.cc View 5 chunks +19 lines, -16 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
prashant.n
ptal
4 years, 7 months ago (2016-05-24 09:34:20 UTC) #3
reveman
lgtm
4 years, 7 months ago (2016-05-25 03:58:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003333002/1
4 years, 7 months ago (2016-05-26 19:07:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 20:41:30 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 20:42:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e52becffdcc78f38589a0e0cdfb0cbaa9587f2b
Cr-Commit-Position: refs/heads/master@{#396274}

Powered by Google App Engine
This is Rietveld 408576698