Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: cc/raster/task.cc

Issue 2003333002: cc: Task should complete as finished or canceled in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test_task_runner
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/raster/raster_buffer_provider_perftest.cc ('k') | cc/raster/task_graph_runner_perftest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/raster/task.cc
diff --git a/cc/raster/task.cc b/cc/raster/task.cc
index 3ead51fcc4d97b945f746de46506e4fe4136219b..28f79eb21c81d2b13d935c47fc4e2fce229503a8 100644
--- a/cc/raster/task.cc
+++ b/cc/raster/task.cc
@@ -13,11 +13,7 @@ TaskState::TaskState() : value_(Value::NEW) {}
TaskState::~TaskState() {
DCHECK(value_ != Value::RUNNING)
<< "Running task should never get destroyed.";
- // TODO(prashant.n): Remove NEW, once all the tests follow the task life
- // cycle correctly. Few tests still do not take care of task states.
- // crbug.com/613814.
- DCHECK(value_ == Value::NEW || value_ == Value::FINISHED ||
- value_ == Value::CANCELED)
+ DCHECK(value_ == Value::FINISHED || value_ == Value::CANCELED)
<< "Task, if scheduled, should get concluded either in FINISHED or "
"CANCELED state.";
}
« no previous file with comments | « cc/raster/raster_buffer_provider_perftest.cc ('k') | cc/raster/task_graph_runner_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698