Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1997743002: cc: Implement test task runner for tests. (Closed)

Created:
4 years, 7 months ago by prashant.n
Modified:
4 years, 6 months ago
Reviewers:
reveman, vmpstr, ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_schedule_complete
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Implement test task runner for tests. This patch implements simple task runner which handles single task. The functions provided in the class can be used for operating over task. BUG=599863 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7c7060263d42c1b95874150f54635113e4b5f3e4 Cr-Commit-Position: refs/heads/master@{#396246}

Patch Set 1 #

Patch Set 2 : feedback #

Patch Set 3 : extended to SoftwareImageDecodeControllerTest #

Total comments: 1

Patch Set 4 : rebase + feedback #

Patch Set 5 : rebase #

Patch Set 6 : taken care new tests #

Patch Set 7 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -94 lines) Patch
M cc/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A cc/test/test_tile_task_runner.h View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A cc/test/test_tile_task_runner.cc View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller_unittest.cc View 1 2 3 22 chunks +47 lines, -74 lines 0 comments Download
M cc/tiles/software_image_decode_controller_unittest.cc View 1 2 3 4 5 6 28 chunks +53 lines, -20 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (8 generated)
prashant.n
PTAL. If looks okay, I'll extend to SoftwareImageDecodeControllerTest.
4 years, 7 months ago (2016-05-19 17:18:54 UTC) #4
ericrk
Seems OK, but having this be a full class doesn't seem that useful. This could ...
4 years, 7 months ago (2016-05-19 23:28:37 UTC) #5
prashant.n
On 2016/05/19 23:28:37, ericrk wrote: > Seems OK, but having this be a full class ...
4 years, 7 months ago (2016-05-20 01:34:06 UTC) #6
prashant.n
ptal.
4 years, 7 months ago (2016-05-20 14:36:58 UTC) #7
ericrk
lgtm Thanks!
4 years, 7 months ago (2016-05-20 17:47:40 UTC) #8
vmpstr
lgtm with a naming suggestion https://codereview.chromium.org/1997743002/diff/40001/cc/test/simple_task_runner.h File cc/test/simple_task_runner.h (right): https://codereview.chromium.org/1997743002/diff/40001/cc/test/simple_task_runner.h#newcode14 cc/test/simple_task_runner.h:14: class SimpleTaskRunner { nit: ...
4 years, 7 months ago (2016-05-20 23:23:19 UTC) #9
reveman
lgtm
4 years, 7 months ago (2016-05-25 03:58:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997743002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997743002/120001
4 years, 6 months ago (2016-05-26 17:38:39 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 6 months ago (2016-05-26 19:00:26 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 19:01:43 UTC) #18
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/7c7060263d42c1b95874150f54635113e4b5f3e4
Cr-Commit-Position: refs/heads/master@{#396246}

Powered by Google App Engine
This is Rietveld 408576698