Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2003223003: [css-grid] Remove TODO as line names are allowed before auto-repeat (Closed)

Created:
4 years, 7 months ago by Manuel Rego
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Remove TODO as line names are allowed before auto-repeat The syntax on the spec has just been updated so we can remove the TODO. See: https://github.com/w3c/csswg-drafts/commit/b9d092a Committed: https://crrev.com/6d8f6cdf7a03f358bbbf15b1d429b99bbf9f9b08 Cr-Commit-Position: refs/heads/master@{#395568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Manuel Rego
4 years, 7 months ago (2016-05-24 07:45:05 UTC) #2
rwlbuis
lgtm
4 years, 7 months ago (2016-05-24 09:39:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003223003/1
4 years, 7 months ago (2016-05-24 09:44:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/142205)
4 years, 7 months ago (2016-05-24 09:53:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003223003/1
4 years, 7 months ago (2016-05-24 10:06:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/142213) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-05-24 10:13:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003223003/1
4 years, 7 months ago (2016-05-24 10:32:03 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 11:23:17 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 11:24:23 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d8f6cdf7a03f358bbbf15b1d429b99bbf9f9b08
Cr-Commit-Position: refs/heads/master@{#395568}

Powered by Google App Engine
This is Rietveld 408576698