third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp - Issue 2003223003: [css-grid] Remove TODO as line names are allowed before auto-repeat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2003223003: [css-grid] Remove TODO as line names are allowed before auto-repeat (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

index 30ba7ff08afdc5fba6435c593e048e388627720a..47e3e7b36bbdef90ad76504bf7207eb87f7d7657 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

@@ -3491,7 +3491,6 @@ static CSSValue* consumeGridTrackList(CSSParserTokenRange& range, CSSParserMode

bool seenAutoRepeat = false;

bool allTracksAreFixedSized = true;

- // TODO(rob.buis): <line-names> should not be able to directly precede <auto-repeat>.

do {

bool isAutoRepeat;

if (range.peek().functionId() == CSSValueRepeat) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »