|
|
Created:
4 years, 7 months ago by krasin Modified:
4 years, 7 months ago CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org, Dirk Pranke Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix expectations for debian deps.
The change is due to launching LTO ([1], [2]) on Linux, which eliminated
some of the unused symbols deps, thus decreasing the effective version
of libdbus-1-3 Chrome depends on.
BUG=453195
[1] http://llvm.org/docs/LinkTimeOptimization.html
[2] https://codereview.chromium.org/2003733004
(actually try bots had run; the line below is to bypass a slow flaky bot)
NOTRY=true
Committed: https://crrev.com/0fe758fd6d99cadd1a533018e5ccce602a8b6cd5
Cr-Commit-Position: refs/heads/master@{#395411}
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
krasin@google.com changed reviewers: + dpranke@chromium.org
The error message from the bot: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux... python ../../chrome/installer/linux/flock_make_package.py linux_package.lock installer/debian/build.sh -o ../Release -b ../Release -a x64 -c unstable -d google_chrome dpkg-shlibdeps: warning: binaries to analyze should already be installed in their package's directory. --- /b/build/slave/google-chrome-rel-linux_64/build/src/out/Release/installer/debian/expected_deps_x64 2016-05-23 11:52:39.688239602 -0700 +++ actual 2016-05-23 13:03:13.860121872 -0700 @@ -4,7 +4,7 @@ libc6 (>= 2.12) libcairo2 (>= 1.6.0) libcups2 (>= 1.4.0) -libdbus-1-3 (>= 1.2.14) +libdbus-1-3 (>= 1.1.4) libexpat1 (>= 1.95.8) libfontconfig1 (>= 2.8.0) libfreetype6 (>= 2.3.9) ERROR: Shared library dependencies changed! If this is intentional, please update: chrome/installer/linux/debian/expected_deps_ia32 chrome/installer/linux/debian/expected_deps_x64
The CQ bit was checked by krasin@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003143002/1
Description was changed from ========== Fix expectations for debian deps. The change is due to launching LTO ([1], [2]) on Linux, which eliminated some of the unused symbols deps, thus decreasing the effective version of libdbus-1-3 Chrome depends on. BUG=453195 ========== to ========== Fix expectations for debian deps. The change is due to launching LTO ([1], [2]) on Linux, which eliminated some of the unused symbols deps, thus decreasing the effective version of libdbus-1-3 Chrome depends on. BUG=453195 [1] http://llvm.org/docs/LinkTimeOptimization.html [2] https://codereview.chromium.org/2003733004 ==========
krasin@google.com changed reviewers: + mmoss@chromium.org, thestig@chromium.org - dpranke@chromium.org
lgtm
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was unchecked by krasin@google.com
All trybots but one succeeded (because they don't actually check for this file). One failed for unrelated NVIDIA flake: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... I am going to submit this w/o waiting for the trybot to formally fail and re-run again, as there's no reasons to do that.
Description was changed from ========== Fix expectations for debian deps. The change is due to launching LTO ([1], [2]) on Linux, which eliminated some of the unused symbols deps, thus decreasing the effective version of libdbus-1-3 Chrome depends on. BUG=453195 [1] http://llvm.org/docs/LinkTimeOptimization.html [2] https://codereview.chromium.org/2003733004 ========== to ========== Fix expectations for debian deps. The change is due to launching LTO ([1], [2]) on Linux, which eliminated some of the unused symbols deps, thus decreasing the effective version of libdbus-1-3 Chrome depends on. BUG=453195 [1] http://llvm.org/docs/LinkTimeOptimization.html [2] https://codereview.chromium.org/2003733004 (actually try bots had run; the line below is to bypass a slow flaky bot) NOTRY=true ==========
The CQ bit was checked by krasin@google.com
On 2016/05/23 21:00:01, krasin wrote: > All trybots but one succeeded (because they don't actually check for this file). > One failed for unrelated NVIDIA flake: > https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... > > I am going to submit this w/o waiting for the trybot to formally fail and re-run > again, as there's no reasons to do that. If compile passed, that's what matters. That's the where packages are generated, and the only place this change would come into play.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003143002/1
> If compile passed, that's what matters. That's the where packages are generated, > and the only place this change would come into play. Yes, compile passed.
Message was sent while issue was closed.
Description was changed from ========== Fix expectations for debian deps. The change is due to launching LTO ([1], [2]) on Linux, which eliminated some of the unused symbols deps, thus decreasing the effective version of libdbus-1-3 Chrome depends on. BUG=453195 [1] http://llvm.org/docs/LinkTimeOptimization.html [2] https://codereview.chromium.org/2003733004 (actually try bots had run; the line below is to bypass a slow flaky bot) NOTRY=true ========== to ========== Fix expectations for debian deps. The change is due to launching LTO ([1], [2]) on Linux, which eliminated some of the unused symbols deps, thus decreasing the effective version of libdbus-1-3 Chrome depends on. BUG=453195 [1] http://llvm.org/docs/LinkTimeOptimization.html [2] https://codereview.chromium.org/2003733004 (actually try bots had run; the line below is to bypass a slow flaky bot) NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix expectations for debian deps. The change is due to launching LTO ([1], [2]) on Linux, which eliminated some of the unused symbols deps, thus decreasing the effective version of libdbus-1-3 Chrome depends on. BUG=453195 [1] http://llvm.org/docs/LinkTimeOptimization.html [2] https://codereview.chromium.org/2003733004 (actually try bots had run; the line below is to bypass a slow flaky bot) NOTRY=true ========== to ========== Fix expectations for debian deps. The change is due to launching LTO ([1], [2]) on Linux, which eliminated some of the unused symbols deps, thus decreasing the effective version of libdbus-1-3 Chrome depends on. BUG=453195 [1] http://llvm.org/docs/LinkTimeOptimization.html [2] https://codereview.chromium.org/2003733004 (actually try bots had run; the line below is to bypass a slow flaky bot) NOTRY=true Committed: https://crrev.com/0fe758fd6d99cadd1a533018e5ccce602a8b6cd5 Cr-Commit-Position: refs/heads/master@{#395411} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0fe758fd6d99cadd1a533018e5ccce602a8b6cd5 Cr-Commit-Position: refs/heads/master@{#395411} |