Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2003733004:
Enable LTO on Linux for the official builds. (Closed)
DescriptionEnable LTO on Linux for the official builds.
This CL turns on Link-Time Optimization for official
builds, which makes the resulting binaries to run faster.
On the dark side, the change increases the link time by 3x-5x,
and is also very memory-hungry. All official bots were
upgraded to have 200+ GB RAM to handle LTO builds. Timeouts
were also accordingly increased.
This CL might cause timeouts / OOMs, if some slaves still
have not enough RAM. Please, revert the CL with pointing
out to the slaves / bots broken by this change.
BUG=453195
Committed: https://crrev.com/7c163521444b7277f2c33bc7bc05667673db7d48
Cr-Commit-Position: refs/heads/master@{#395365}
Patch Set 1 #
Messages
Total messages: 26 (11 generated)
Description was changed from ========== Enable LTO on Linux for the official builds. This CL turns on Link-Time Optimization for official builds. It increases link time by 3x-5x, and is also very memory-hungry. All official bots were upgraded to have 200+ GB RAM to handle LTO builds. Timeouts were also accordingly increased. This CL might cause timeouts / OOMs, if some slaves still have not enough RAM. Please, revert the CL with pointing out to the slaves / bots broken by this change. BUG=453195 ========== to ========== Enable LTO on Linux for the official builds. This CL turns on Link-Time Optimization for official builds, which makes the resulting binaries to run faster. On the dark side, the change increases the link time by 3x-5x, and is also very memory-hungry. All official bots were upgraded to have 200+ GB RAM to handle LTO builds. Timeouts were also accordingly increased. This CL might cause timeouts / OOMs, if some slaves still have not enough RAM. Please, revert the CL with pointing out to the slaves / bots broken by this change. BUG=453195 ==========
The CQ bit was checked by krasin@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003733004/1
Description was changed from ========== Enable LTO on Linux for the official builds. This CL turns on Link-Time Optimization for official builds, which makes the resulting binaries to run faster. On the dark side, the change increases the link time by 3x-5x, and is also very memory-hungry. All official bots were upgraded to have 200+ GB RAM to handle LTO builds. Timeouts were also accordingly increased. This CL might cause timeouts / OOMs, if some slaves still have not enough RAM. Please, revert the CL with pointing out to the slaves / bots broken by this change. BUG=453195 ========== to ========== Enable LTO on Linux for the official builds. This CL turns on Link-Time Optimization for official builds, which makes the resulting binaries to run faster. On the dark side, the change increases the link time by 3x-5x, and is also very memory-hungry. All official bots were upgraded to have 200+ GB RAM to handle LTO builds. Timeouts were also accordingly increased. This CL might cause timeouts / OOMs, if some slaves still have not enough RAM. Please, revert the CL with pointing out to the slaves / bots broken by this change. BUG=453195 ==========
krasin@google.com changed reviewers: + dpranke@chromium.org
Hi Dirk, please, review this 'Launch LTO on Linux' CL. It's largely an adoption of my 'Launch CFI on Linux' which I submitted and reverted back in December 2015: https://codereview.chromium.org/1529993002/ I intend to submit this CL on Monday, before noon. I will only submit if Infra weather looks good. At the same time, I would like to have the CL approved today, so that there's no artificial delay at the launch day. Please, take a look.
lgtm
Thanks! I am all set for the launch (I hope).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Dirk, Nico, I am about to launch LTO on Linux. Most likely, it will break the official desktop builder with some minor changes to chrome/installer/linux/debian/expected_deps_x64 (like in [1]) or chrome/installer/linux/rpm/expected_deps_x86_64. The reason for the deps change might be that LTO could optimize out some of the symbols, and the required .so versions might become lower. I failed to verify that locally, as it requires exactly the same OS configuration, and just doing it on GCE / Precise x86-64 won't probably be a good guess. Do you know of a good way to verify that? Do you think it's okay to send this CL and then submit a follow-up fix, when the changes in dependencies are discovered by the bots? I am leaning in favor of the latter, as it's not a failure that would close a tree, and the fix would be trivial. [1] https://codereview.chromium.org/1529993002/diff/1/chrome/installer/linux/debi... [2]
The CQ bit was checked by krasin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003733004/1
On 2016/05/23 06:04:53, krasin wrote: > I failed to verify that locally, as it requires exactly the same OS > configuration, and just doing it on GCE / Precise x86-64 won't probably be a > good guess. > > Do you know of a good way to verify that? Do you think it's okay to send this CL > and then submit a follow-up fix, when the changes in dependencies are discovered > by the bots? I am leaning in favor of the latter, as it's not a failure that > would close a tree, and the fix would be trivial. The official builders should be using the same configuration you're using, since we use sysroots. That said, I wrote "should" instead of "will" for a reason ;). I think it's fine to land this and see what happens.
The CQ bit was unchecked by krasin@google.com
The CQ bit was checked by krasin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003733004/1
Message was sent while issue was closed.
Description was changed from ========== Enable LTO on Linux for the official builds. This CL turns on Link-Time Optimization for official builds, which makes the resulting binaries to run faster. On the dark side, the change increases the link time by 3x-5x, and is also very memory-hungry. All official bots were upgraded to have 200+ GB RAM to handle LTO builds. Timeouts were also accordingly increased. This CL might cause timeouts / OOMs, if some slaves still have not enough RAM. Please, revert the CL with pointing out to the slaves / bots broken by this change. BUG=453195 ========== to ========== Enable LTO on Linux for the official builds. This CL turns on Link-Time Optimization for official builds, which makes the resulting binaries to run faster. On the dark side, the change increases the link time by 3x-5x, and is also very memory-hungry. All official bots were upgraded to have 200+ GB RAM to handle LTO builds. Timeouts were also accordingly increased. This CL might cause timeouts / OOMs, if some slaves still have not enough RAM. Please, revert the CL with pointing out to the slaves / bots broken by this change. BUG=453195 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable LTO on Linux for the official builds. This CL turns on Link-Time Optimization for official builds, which makes the resulting binaries to run faster. On the dark side, the change increases the link time by 3x-5x, and is also very memory-hungry. All official bots were upgraded to have 200+ GB RAM to handle LTO builds. Timeouts were also accordingly increased. This CL might cause timeouts / OOMs, if some slaves still have not enough RAM. Please, revert the CL with pointing out to the slaves / bots broken by this change. BUG=453195 ========== to ========== Enable LTO on Linux for the official builds. This CL turns on Link-Time Optimization for official builds, which makes the resulting binaries to run faster. On the dark side, the change increases the link time by 3x-5x, and is also very memory-hungry. All official bots were upgraded to have 200+ GB RAM to handle LTO builds. Timeouts were also accordingly increased. This CL might cause timeouts / OOMs, if some slaves still have not enough RAM. Please, revert the CL with pointing out to the slaves / bots broken by this change. BUG=453195 Committed: https://crrev.com/7c163521444b7277f2c33bc7bc05667673db7d48 Cr-Commit-Position: refs/heads/master@{#395365} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7c163521444b7277f2c33bc7bc05667673db7d48 Cr-Commit-Position: refs/heads/master@{#395365}
Message was sent while issue was closed.
thestig@chromium.org changed reviewers: + thestig@chromium.org
Message was sent while issue was closed.
I suspect this might be causing https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux... -> need to update the Linux expected installer DEPS, since it's reducing requirements, not adding them.
Message was sent while issue was closed.
On 2016/05/23 21:25:08, Lei Zhang wrote: > I suspect this might be causing > https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux... > -> need to update the Linux expected installer DEPS, since it's reducing > requirements, not adding them. ... and you are way ahead of me: https://codereview.chromium.org/2003143002/
Message was sent while issue was closed.
On 2016/05/23 21:26:04, Lei Zhang wrote: > On 2016/05/23 21:25:08, Lei Zhang wrote: > > I suspect this might be causing > > > https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux... > > -> need to update the Linux expected installer DEPS, since it's reducing > > requirements, not adding them. > > ... and you are way ahead of me: https://codereview.chromium.org/2003143002/ Yeah, sorry, I didn't update the CL discussion, just the linked bug: https://bugs.chromium.org/p/chromium/issues/detail?id=453195#c48 I also notified mek@ via chat (one of the current build sheriffs).
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2015703004/ by agrieve@chromium.org. The reason for reverting is: Breaks android x64 builds. https://bugs.chromium.org/p/chromium/issues/detail?id=615039. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
