third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h - Issue 2003033004: Split custom element script use and move it into bindings

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h

Issue 2003033004: Split custom element script use and move it into bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing CORE_EXPORT header. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/V8CustomElementPerContextData.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h

index 0b9731875776ed64762420bf69ea28e3412aec3f..990c53d6588356fbc7966a06c7dec3ad4abd6966 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h

@@ -32,16 +32,16 @@

#define V8PerContextData_h

#include "bindings/core/v8/ScopedPersistent.h"

-#include "bindings/core/v8/V0CustomElementBinding.h"

+#include "bindings/core/v8/V8CustomElementPerContextData.h"

#include "bindings/core/v8/V8GlobalValueMap.h"

#include "bindings/core/v8/WrapperTypeInfo.h"

#include "core/CoreExport.h"

#include "gin/public/context_holder.h"

#include "gin/public/gin_embedders.h"

+#include "platform/heap/Handle.h"

#include "wtf/Allocator.h"

#include "wtf/HashMap.h"

#include "wtf/PassOwnPtr.h"

-#include "wtf/Vector.h"

#include "wtf/text/AtomicString.h"

#include "wtf/text/AtomicStringHash.h"

#include <v8.h>

@@ -84,7 +84,7 @@ public:

v8::Local<v8::Object> prototypeForType(const WrapperTypeInfo*);

- void addCustomElementBinding(PassOwnPtr<V0CustomElementBinding>);

+ V8CustomElementPerContextData* customElements();

V8DOMActivityLogger* activityLogger() const { return m_activityLogger; }

void setActivityLogger(V8DOMActivityLogger* activityLogger) { m_activityLogger = activityLogger; }

@@ -113,8 +113,7 @@ private:

ScopedPersistent<v8::Context> m_context;

ScopedPersistent<v8::Value> m_errorPrototype;

- typedef Vector<OwnPtr<V0CustomElementBinding>> V0CustomElementBindingList;

- V0CustomElementBindingList m_customElementBindings;

+ Persistent<V8CustomElementPerContextData> m_customElements;

haraken 2016/05/26 08:33:46 Does this need to be a member of V8PerContextData?

dominicc (has gone to gerrit) 2016/05/27 04:54:17 OK, I tried to do this. Because putting things in

// This is owned by a static hash map in V8DOMActivityLogger.

V8DOMActivityLogger* m_activityLogger;