Split custom element script use and move it into bindings

third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef V8PerContextData_h
 #define V8PerContextData_h
 
 #include "bindings/core/v8/ScopedPersistent.h"
-#include "bindings/core/v8/V0CustomElementBinding.h"
+#include "bindings/core/v8/V8CustomElementPerContextData.h"
 #include "bindings/core/v8/V8GlobalValueMap.h"
 #include "bindings/core/v8/WrapperTypeInfo.h"
 #include "core/CoreExport.h"
 #include "gin/public/context_holder.h"
 #include "gin/public/gin_embedders.h"
+#include "platform/heap/Handle.h"
 #include "wtf/Allocator.h"
 #include "wtf/HashMap.h"
 #include "wtf/PassOwnPtr.h"
-#include "wtf/Vector.h"
 #include "wtf/text/AtomicString.h"
 #include "wtf/text/AtomicStringHash.h"
 #include <v8.h>
 
 namespace blink {
 
 class V8DOMActivityLogger;
 class V8PerContextData;
 
 enum V8ContextEmbedderDataField {
@@ skipping 22 matching lines @@
     }
 
     v8::Local<v8::Function> constructorForType(const WrapperTypeInfo* type)
     {
         v8::Local<v8::Function> interfaceObject = m_constructorMap.Get(type);
         return (!interfaceObject.IsEmpty()) ? interfaceObject : constructorForTypeSlowCase(type);
     }
 
     v8::Local<v8::Object> prototypeForType(const WrapperTypeInfo*);
 
-    void addCustomElementBinding(PassOwnPtr<V0CustomElementBinding>);
+    V8CustomElementPerContextData* customElements();
 
     V8DOMActivityLogger* activityLogger() const { return m_activityLogger; }
     void setActivityLogger(V8DOMActivityLogger* activityLogger) { m_activityLogger = activityLogger; }
 
     v8::Local<v8::Value> compiledPrivateScript(String);
     void setCompiledPrivateScript(String, v8::Local<v8::Value>);
 
 private:
     V8PerContextData(v8::Local<v8::Context>);
 
     v8::Local<v8::Object> createWrapperFromCacheSlowCase(const WrapperTypeInfo*);
     v8::Local<v8::Function> constructorForTypeSlowCase(const WrapperTypeInfo*);
 
     v8::Isolate* m_isolate;
 
     // For each possible type of wrapper, we keep a boilerplate object.
     // The boilerplate is used to create additional wrappers of the same type.
     typedef V8GlobalValueMap<const WrapperTypeInfo*, v8::Object, v8::kNotWeak> WrapperBoilerplateMap;
     WrapperBoilerplateMap m_wrapperBoilerplates;
 
     typedef V8GlobalValueMap<const WrapperTypeInfo*, v8::Function, v8::kNotWeak> ConstructorMap;
     ConstructorMap m_constructorMap;
 
     OwnPtr<gin::ContextHolder> m_contextHolder;
 
     ScopedPersistent<v8::Context> m_context;
     ScopedPersistent<v8::Value> m_errorPrototype;
 
-    typedef Vector<OwnPtr<V0CustomElementBinding>> V0CustomElementBindingList;
-    V0CustomElementBindingList m_customElementBindings;
+    Persistent<V8CustomElementPerContextData> m_customElements;

[haraken, 2016/05/26 08:33:46]

Does this need to be a member of V8PerContextData? I'm feeling that
V8CustomElementPerContextData is something that is more associated with
ExecutionContext.

[dominicc (has gone to gerrit), 2016/05/27 04:54:17]

OK, I tried to do this. Because putting things in core/dom would mean making
them the abstract types, I simply stored these on CustomElementsRegistry in
keeping with the split esprehn wants (I think.)

 
     // This is owned by a static hash map in V8DOMActivityLogger.
     V8DOMActivityLogger* m_activityLogger;
 
     V8GlobalValueMap<String, v8::Value, v8::kNotWeak> m_compiledPrivateScript;
 };
 
 } // namespace blink
 
 #endif // V8PerContextData_h