third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp - Issue 2003033004: Split custom element script use and move it into bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

Issue 2003033004: Split custom element script use and move it into bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing CORE_EXPORT header. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h ('K') | « third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

index 4bf774cded9550a56b8509f51c91c8d6d8c21853..ad65abcd96b2acd4a0a63a68dc9b30726793a037 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

@@ -145,9 +145,11 @@ v8::Local<v8::Object> V8PerContextData::prototypeForType(const WrapperTypeInfo*

return prototypeValue.As<v8::Object>();

}

-void V8PerContextData::addCustomElementBinding(PassOwnPtr<V0CustomElementBinding> binding)

+V8CustomElementPerContextData* V8PerContextData::customElements()

{

- m_customElementBindings.append(std::move(binding));

+ if (!m_customElements.get())

+ m_customElements = new V8CustomElementPerContextData();

+ return m_customElements;

}

v8::Local<v8::Value> V8PerContextData::compiledPrivateScript(String className)