Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: chrome/browser/ui/views/critical_notification_bubble_view.cc

Issue 2002673003: i18n of several browser messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address first review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/critical_notification_bubble_view.cc
diff --git a/chrome/browser/ui/views/critical_notification_bubble_view.cc b/chrome/browser/ui/views/critical_notification_bubble_view.cc
index ded52e7bc5d936e5251b4921819a180f8901aa7b..5e48c903ba65157e1f068eb3df0cc711d40b3524 100644
--- a/chrome/browser/ui/views/critical_notification_bubble_view.cc
+++ b/chrome/browser/ui/views/critical_notification_bubble_view.cc
@@ -4,7 +4,7 @@
#include "chrome/browser/ui/views/critical_notification_bubble_view.h"
-#include "base/strings/string_number_conversions.h"
+#include "base/i18n/message_formatter.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/lifetime/application_lifetime.h"
@@ -83,10 +83,10 @@ void CriticalNotificationBubbleView::OnCountdown() {
base::string16 CriticalNotificationBubbleView::GetWindowTitle() const {
int seconds = GetRemainingTime();
- return seconds > 0 ? l10n_util::GetStringFUTF16(
- IDS_CRITICAL_NOTIFICATION_HEADLINE,
- l10n_util::GetStringUTF16(IDS_PRODUCT_NAME),
- base::IntToString16(seconds))
+ return seconds > 0 ? base::i18n::MessageFormatter::FormatWithNumberedArgs(
+ l10n_util::GetStringUTF16(
+ IDS_CRITICAL_NOTIFICATION_HEADLINE),
+ l10n_util::GetStringUTF16(IDS_PRODUCT_NAME), seconds)
: l10n_util::GetStringFUTF16(
IDS_CRITICAL_NOTIFICATION_HEADLINE_ALTERNATE,
l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));

Powered by Google App Engine
This is Rietveld 408576698