chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm - Issue 2002673003: i18n of several browser messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Issue 2002673003: i18n of several browser messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address first review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/views/critical_notification_bubble_view.cc » ('j') | chrome/browser/ui/website_settings/website_settings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

index 8b1f3e1d329cfe9052f4de526ec7d8f7668bed69..3e1ae265eddb7e8e0fbd6e2b67f776ebc7e1902c 100644

--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

@@ -942,13 +942,11 @@ NSPoint AnchorPointForWindow(NSWindow* parent) {

base::string16 thirdPartyLabelText;

for (const auto& i : cookieInfoList) {

if (i.is_first_party) {

- firstPartyLabelText =

- l10n_util::GetStringFUTF16(IDS_WEBSITE_SETTINGS_FIRST_PARTY_SITE_DATA,

- base::IntToString16(i.allowed));

+ firstPartyLabelText = l10n_util::GetPluralStringFUTF16(

+ IDS_WEBSITE_SETTINGS_FIRST_PARTY_SITE_DATA, i.allowed);

} else {

- thirdPartyLabelText =

- l10n_util::GetStringFUTF16(IDS_WEBSITE_SETTINGS_THIRD_PARTY_SITE_DATA,

- base::IntToString16(i.allowed));

+ thirdPartyLabelText = l10n_util::GetPluralStringFUTF16(

+ IDS_WEBSITE_SETTINGS_THIRD_PARTY_SITE_DATA, i.allowed);

}