Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4271)

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 2002673003: i18n of several browser messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address first review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
index a2ec2588b18933ff2c733c4f240495dc717f6bbe..f169ba21a331aae4f5707e0b2df08279ef0611aa 100644
--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
@@ -9,10 +9,10 @@
#include <algorithm>
#include <vector>
+#include "base/i18n/number_formatting.h"
#include "base/i18n/rtl.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
-#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/certificate_viewer.h"
@@ -555,13 +555,11 @@ void WebsiteSettingsPopupView::SetCookieInfo(
base::string16 third_party_label_text;
for (const auto& i : cookie_info_list) {
if (i.is_first_party) {
- first_party_label_text =
- l10n_util::GetStringFUTF16(IDS_WEBSITE_SETTINGS_FIRST_PARTY_SITE_DATA,
- base::IntToString16(i.allowed));
+ first_party_label_text = l10n_util::GetPluralStringFUTF16(
+ IDS_WEBSITE_SETTINGS_FIRST_PARTY_SITE_DATA, i.allowed);
} else {
- third_party_label_text =
- l10n_util::GetStringFUTF16(IDS_WEBSITE_SETTINGS_THIRD_PARTY_SITE_DATA,
- base::IntToString16(i.allowed));
+ third_party_label_text = l10n_util::GetPluralStringFUTF16(
+ IDS_WEBSITE_SETTINGS_THIRD_PARTY_SITE_DATA, i.allowed);
}
}

Powered by Google App Engine
This is Rietveld 408576698