Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2002253002: Remove sRGB overrides on GrTextureParams. Use GrPaint flags instead. (Closed)

Created:
4 years, 7 months ago by Brian Osman
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove sRGB overrides on GrTextureParams. Use GrPaint flags instead. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2002253002 Committed: https://skia.googlesource.com/skia/+/a167e74b4bb78cfbbec3d8768e5853cd0b9314ab

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -42 lines) Patch
M include/gpu/GrTextureParams.h View 7 chunks +1 line, -30 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -1 line 1 comment Download
M src/gpu/gl/GrGLGpu.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002253002/1
4 years, 7 months ago (2016-05-23 20:51:58 UTC) #3
Brian Osman
https://codereview.chromium.org/2002253002/diff/1/src/gpu/gl/GrGLGpu.h File src/gpu/gl/GrGLGpu.h (right): https://codereview.chromium.org/2002253002/diff/1/src/gpu/gl/GrGLGpu.h#newcode60 src/gpu/gl/GrGLGpu.h:60: void bindTexture(int unitIdx, const GrTextureParams& params, bool allowSRGBInputs, Just ...
4 years, 7 months ago (2016-05-23 20:52:05 UTC) #5
robertphillips
lgtm
4 years, 7 months ago (2016-05-23 20:57:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-23 21:10:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002253002/1
4 years, 7 months ago (2016-05-23 21:15:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/9906)
4 years, 7 months ago (2016-05-23 21:17:29 UTC) #12
Brian Osman
Brian, PTAL. The GrTextureParams.h changes are just the removal of API I added a while ...
4 years, 7 months ago (2016-05-23 21:36:31 UTC) #13
bsalomon
lgtm
4 years, 7 months ago (2016-05-23 21:39:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002253002/1
4 years, 7 months ago (2016-05-24 13:17:53 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 13:18:51 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a167e74b4bb78cfbbec3d8768e5853cd0b9314ab

Powered by Google App Engine
This is Rietveld 408576698