Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 2002243002: Gets mash to use WmToplevelWindowEventHandler (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gets mash to use WmToplevelWindowEventHandler And wires up a couple of ash LayoutManagers that the resize code uses. BUG=603369 TEST=covered by tests Committed: https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755 Cr-Commit-Position: refs/heads/master@{#395453}

Patch Set 1 #

Patch Set 2 : fix registration #

Total comments: 5

Patch Set 3 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -496 lines) Patch
M ash/wm/common/wm_toplevel_window_event_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mash/wm/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M mash/wm/bridge/wm_globals_mus.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mash/wm/bridge/wm_root_window_controller_mus.cc View 1 chunk +1 line, -0 lines 0 comments Download
A mash/wm/drag_window_resizer.h View 1 chunk +38 lines, -0 lines 0 comments Download
A mash/wm/drag_window_resizer.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M mash/wm/frame/move_event_handler.h View 3 chunks +10 lines, -10 lines 0 comments Download
M mash/wm/frame/move_event_handler.cc View 1 2 4 chunks +16 lines, -56 lines 0 comments Download
D mash/wm/frame/move_loop.h View 1 chunk +0 lines, -129 lines 0 comments Download
D mash/wm/frame/move_loop.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D mash/wm/frame/move_loop_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M mash/wm/root_window_controller.cc View 1 2 chunks +17 lines, -0 lines 0 comments Download
M mash/wm/shelf_layout_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
sky
4 years, 7 months ago (2016-05-23 20:29:20 UTC) #3
James Cook
LGTM https://codereview.chromium.org/2002243002/diff/20001/mash/wm/drag_window_resizer.cc File mash/wm/drag_window_resizer.cc (right): https://codereview.chromium.org/2002243002/diff/20001/mash/wm/drag_window_resizer.cc#newcode23 mash/wm/drag_window_resizer.cc:23: // http://crbug.com/613199. Nice to see bugs filed for ...
4 years, 7 months ago (2016-05-23 21:53:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002243002/40001
4 years, 7 months ago (2016-05-23 22:03:17 UTC) #7
sky
https://codereview.chromium.org/2002243002/diff/20001/mash/wm/shelf_layout_manager.cc File mash/wm/shelf_layout_manager.cc (right): https://codereview.chromium.org/2002243002/diff/20001/mash/wm/shelf_layout_manager.cc#newcode38 mash/wm/shelf_layout_manager.cc:38: // Phanton windows end up in this container, ignore ...
4 years, 7 months ago (2016-05-23 22:23:26 UTC) #8
sky
I forgot to hit 'done' for this one too. Sorry about that. https://codereview.chromium.org/2002243002/diff/20001/mash/wm/frame/move_event_handler.cc File mash/wm/frame/move_event_handler.cc ...
4 years, 7 months ago (2016-05-23 22:25:44 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-23 23:14:18 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 23:15:36 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755
Cr-Commit-Position: refs/heads/master@{#395453}

Powered by Google App Engine
This is Rietveld 408576698