mash/wm/shelf_layout_manager.cc - Issue 2002243002: Gets mash to use WmToplevelWindowEventHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/wm/shelf_layout_manager.cc

Issue 2002243002: Gets mash to use WmToplevelWindowEventHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mash/wm/shelf_layout_manager.cc

diff --git a/mash/wm/shelf_layout_manager.cc b/mash/wm/shelf_layout_manager.cc

index 44fb732b40bd848e4b1675d43a870094612c0e5c..7e07f58f26a8848f9a1adb5ec9c60ec832f56d1c 100644

--- a/mash/wm/shelf_layout_manager.cc

+++ b/mash/wm/shelf_layout_manager.cc

@@ -35,7 +35,7 @@ mus::Window* ShelfLayoutManager::GetShelfWindow() {

void ShelfLayoutManager::LayoutWindow(mus::Window* window) {

if (GetAshWindowType(window) != mojom::AshWindowType::SHELF) {

- NOTREACHED() << "Unknown window in USER_SHELF container.";

+ // Phantom windows end up in this container, ignore them.

return;

}

gfx::Size size = GetWindowPreferredSize(window);

« no previous file with comments | « mash/wm/root_window_controller.cc ('k') | no next file » | no next file with comments »