Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2002233002: gyp: clean up warnings with clang-3.8 (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

gyp: clean up warnings with clang-3.8 Also: update zlib DEPS. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2002233002 Committed: https://skia.googlesource.com/skia/+/3d5942e8a4fe8845c49a7afaf8248c4e9b5b7520

Patch Set 1 #

Patch Set 2 : 2016-05-23 (Monday) 16:41:37 EDT #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M gyp/codec.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M gyp/lua.gyp View 1 chunk +5 lines, -6 lines 0 comments Download
M gyp/zlib.gyp View 1 1 chunk +8 lines, -2 lines 1 comment Download

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002233002/1
4 years, 7 months ago (2016-05-23 19:52:54 UTC) #3
hal.canary
ptal
4 years, 7 months ago (2016-05-23 20:00:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-23 20:07:12 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002233002/20001
4 years, 7 months ago (2016-05-23 20:44:50 UTC) #10
bungeman-skia
Why not? lgtm https://codereview.chromium.org/2002233002/diff/20001/gyp/zlib.gyp File gyp/zlib.gyp (right): https://codereview.chromium.org/2002233002/diff/20001/gyp/zlib.gyp#newcode25 gyp/zlib.gyp:25: '-Wno-shift-negative-value', It would be nice to ...
4 years, 7 months ago (2016-05-23 20:53:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002233002/20001
4 years, 7 months ago (2016-05-23 21:01:57 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 21:02:58 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3d5942e8a4fe8845c49a7afaf8248c4e9b5b7520

Powered by Google App Engine
This is Rietveld 408576698