Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: gyp/zlib.gyp

Issue 2002233002: gyp: clean up warnings with clang-3.8 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: 2016-05-23 (Monday) 16:41:37 EDT Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/lua.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/zlib.gyp
diff --git a/gyp/zlib.gyp b/gyp/zlib.gyp
index 43cf6abfd23c5776994a03852249a6aabe18e77f..6263c6697b9d2381d4d0cd6cfed4ed29437daa64 100644
--- a/gyp/zlib.gyp
+++ b/gyp/zlib.gyp
@@ -19,8 +19,14 @@
},
}, {
'type': 'static_library',
- 'cflags': [ '-Wno-unused-value' ],
- 'xcode_settings': { 'WARNING_CFLAGS': [ '-Wno-unused-value', ], },
+ 'variables': {
+ 'skia_zlib_flags' : [
+ '-Wno-unused-value',
+ '-Wno-shift-negative-value',
bungeman-skia 2016/05/23 20:53:10 It would be nice to comment here that this was alr
+ ],
+ },
+ 'cflags': [ '<@(skia_zlib_flags)' ],
+ 'xcode_settings': { 'WARNING_CFLAGS': [ '<@(skia_zlib_flags)' ], },
'sources': [
'../third_party/externals/zlib/adler32.c',
'../third_party/externals/zlib/compress.c',
« no previous file with comments | « gyp/lua.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698