Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: gyp/lua.gyp

Issue 2002233002: gyp: clean up warnings with clang-3.8 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: 2016-05-23 (Monday) 16:41:37 EDT Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/codec.gyp ('k') | gyp/zlib.gyp » ('j') | gyp/zlib.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/lua.gyp
diff --git a/gyp/lua.gyp b/gyp/lua.gyp
index e0ad23a02242563438391229ea0c7a9f65e3029f..56080e47fa55318d3ec24a4ca36624daf90ad488 100644
--- a/gyp/lua.gyp
+++ b/gyp/lua.gyp
@@ -59,16 +59,15 @@
'defines': [
"getlocaledecpoint()='.'",
],
- 'cflags': [
- '-Wno-parentheses-equality',
- '-Wno-pointer-bool-conversion',
- ],
- 'xcode_settings': {
- 'WARNING_CFLAGS': [
+ 'variables': {
+ 'skia_lua_flags' : [
'-Wno-parentheses-equality',
'-Wno-pointer-bool-conversion',
+ '-Wno-array-bounds',
],
},
+ 'cflags': [ '<@(skia_lua_flags)' ],
+ 'xcode_settings': { 'WARNING_CFLAGS': [ '<@(skia_lua_flags)' ], },
'conditions': [
['skia_os != "win"',
{
« no previous file with comments | « gyp/codec.gyp ('k') | gyp/zlib.gyp » ('j') | gyp/zlib.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698