Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2002193002: [telemetry] Rename TraceData.[Has,Get]EventsFor to [Has,Get]TraceFor (Closed)

Created:
4 years, 7 months ago by charliea (OOO until 10-5)
Modified:
4 years, 7 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, rnephew (Reviews Here), perezju
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[telemetry] Rename TraceData.[Has,Get]EventsFor to [Has,Get]TraceFor This is part of the transition from the old world, where only events are contained in part, to the new world, where a part contain both events and metadata. This is necessary in order to get Chrome/Telemetry clock sync working. BUG=catapult:#2341 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8fa1ba412a7ded4228e3ee696f4723b01f7a3b61

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
charliea (OOO until 10-5)
4 years, 7 months ago (2016-05-23 18:38:06 UTC) #2
nednguyen
lgtm
4 years, 7 months ago (2016-05-23 18:38:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002193002/1
4 years, 7 months ago (2016-05-23 18:42:12 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 19:06:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698