Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1883)

Unified Diff: telemetry/telemetry/timeline/trace_data.py

Issue 2002193002: [telemetry] Rename TraceData.[Has,Get]EventsFor to [Has,Get]TraceFor (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/timeline/trace_data.py
diff --git a/telemetry/telemetry/timeline/trace_data.py b/telemetry/telemetry/timeline/trace_data.py
index 0f5a4600c35cd8b8d21b27303b8f116956d3b754..62b64fc10abe7048cb849e251d0cfd340bfc70a7 100644
--- a/telemetry/telemetry/timeline/trace_data.py
+++ b/telemetry/telemetry/timeline/trace_data.py
@@ -52,7 +52,7 @@ ALL_TRACE_PARTS = {BATTOR_TRACE_PART,
TELEMETRY_PART}
-def _HasEventsFor(part, raw):
+def _HasTraceFor(part, raw):
assert isinstance(part, TraceDataPart)
if part.raw_field_name not in raw:
return False
@@ -136,11 +136,11 @@ class TraceData(object):
'value': v
}
- def HasEventsFor(self, part):
- return _HasEventsFor(part, self._raw_data)
+ def HasTraceFor(self, part):
+ return _HasTraceFor(part, self._raw_data)
- def GetEventsFor(self, part):
- if not self.HasEventsFor(part):
+ def GetTraceFor(self, part):
+ if not self.HasTraceFor(part):
return []
assert isinstance(part, TraceDataPart)
return self._raw_data[part.raw_field_name]
@@ -198,5 +198,5 @@ class TraceDataBuilder(object):
self._raw_data.setdefault(part.raw_field_name, []).extend(events)
- def HasEventsFor(self, part):
- return _HasEventsFor(part, self._raw_data)
+ def HasTraceFor(self, part):
+ return _HasTraceFor(part, self._raw_data)
« no previous file with comments | « telemetry/telemetry/timeline/tab_id_importer.py ('k') | telemetry/telemetry/timeline/trace_data_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698