telemetry/telemetry/core/tracing_controller_unittest.py - Issue 2002193002: [telemetry] Rename TraceData.[Has,Get]EventsFor to [Has,Get]TraceFor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: telemetry/telemetry/core/tracing_controller_unittest.py

Issue 2002193002: [telemetry] Rename TraceData.[Has,Get]EventsFor to [Has,Get]TraceFor (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import time	5 import time

6	6

7 from battor import battor_wrapper	7 from battor import battor_wrapper

8 from telemetry import decorators	8 from telemetry import decorators

9 from telemetry.core import platform as platform_module	9 from telemetry.core import platform as platform_module

10 from telemetry.testing import browser_test_case	10 from telemetry.testing import browser_test_case

(...skipping 186 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
197	197

198 tracing_controller = self._browser.platform.tracing_controller	198 tracing_controller = self._browser.platform.tracing_controller

199 config = tracing_config.TracingConfig()	199 config = tracing_config.TracingConfig()

200 config.enable_battor_trace = True	200 config.enable_battor_trace = True

201 tracing_controller.StartTracing(config)	201 tracing_controller.StartTracing(config)

202 # We wait 1s before starting and stopping tracing to avoid crbug.com/602266,	202 # We wait 1s before starting and stopping tracing to avoid crbug.com/602266,

203 # which would cause a crash otherwise.	203 # which would cause a crash otherwise.

204 time.sleep(1)	204 time.sleep(1)

205 trace_data = tracing_controller.StopTracing()	205 trace_data = tracing_controller.StopTracing()

206 self.assertTrue(	206 self.assertTrue(

207 trace_data.HasEventsFor(trace_data_module.BATTOR_TRACE_PART))	207 trace_data.HasTraceFor(trace_data_module.BATTOR_TRACE_PART))

OLD	NEW