Change "bool createdByParser" of createElement() to enum

Change "bool createdByParser" of createElement() to enum

The "create an element"[1] defines "synchronous custom elements flag"
that is set to false if:
1. To clone a node[2].
2. The parser was originally created for the HTML fragment parsing
   algorithm[3].

This patch changes "bool createdByParser" of createElement() to an enum
so that callers can pass this flag to "create an element"[1].

Using the "synchronous custom elements flag" is not implemented yet,
and thus no behavior changes.

[1] https://dom.spec.whatwg.org/#concept-create-element
[2] https://dom.spec.whatwg.org/#concept-node-clone
[3] https://html.spec.whatwg.org/#create-an-element-for-the-token

BUG=594918
Committed: https://crrev.com/7b0c4a78866841553fe991142d3a516c89f5f851
Cr-Commit-Position: refs/heads/master@{#396125}

[kojii, 2016-05-24 07:31:45]

Description was changed from

==========
Change bool createdByParser to enum to add synchronous custom elements flag

BUG=
==========

to

==========
Change "bool createdByParser" of createElement() to enum

The "create an element"[1] defines "synchronous custom elements flag"
that is set to false if:
1. To clone a node[2].
2. The parser was originally created for the HTML fragment parsing
   algorithm[3].

This patch changes "bool createdByParser" of createElement() to an enum
so that callers can pass this flag down to "create an element"[1].

Using the "synchronous custom elements flag" is not implemented yet,
and thus no behavior changes.

[1] https://dom.spec.whatwg.org/#concept-create-element
[2] https://dom.spec.whatwg.org/#concept-node-clone
[3] https://html.spec.whatwg.org/#create-an-element-for-the-token

BUG=594918
==========

[kojii, 2016-05-24 07:35:59]

Description was changed from

==========
Change "bool createdByParser" of createElement() to enum

The "create an element"[1] defines "synchronous custom elements flag"
that is set to false if:
1. To clone a node[2].
2. The parser was originally created for the HTML fragment parsing
   algorithm[3].

This patch changes "bool createdByParser" of createElement() to an enum
so that callers can pass this flag down to "create an element"[1].

Using the "synchronous custom elements flag" is not implemented yet,
and thus no behavior changes.

[1] https://dom.spec.whatwg.org/#concept-create-element
[2] https://dom.spec.whatwg.org/#concept-node-clone
[3] https://html.spec.whatwg.org/#create-an-element-for-the-token

BUG=594918
==========

to

==========
Change "bool createdByParser" of createElement() to enum

The "create an element"[1] defines "synchronous custom elements flag"
that is set to false if:
1. To clone a node[2].
2. The parser was originally created for the HTML fragment parsing
   algorithm[3].

This patch changes "bool createdByParser" of createElement() to an enum
so that callers can pass this flag to "create an element"[1].

Using the "synchronous custom elements flag" is not implemented yet,
and thus no behavior changes.

[1] https://dom.spec.whatwg.org/#concept-create-element
[2] https://dom.spec.whatwg.org/#concept-node-clone
[3] https://html.spec.whatwg.org/#create-an-element-for-the-token

BUG=594918
==========

[kojii, 2016-05-24 08:13:15]

kojii@chromium.org changed reviewers:
+ dominicc@chromium.org, yosin@chromium.org

[kojii, 2016-05-24 08:13:15]

PTAL. This depends on the other "add hook" patch.

[yosin_UTC9, 2016-05-24 08:53:53]

https://codereview.chromium.org/2002063003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.h (right):

https://codereview.chromium.org/2002063003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.h:217: enum CreateElementFlags {
Is this bit flag? If not, please use |enum class| to allow forward declaration?

[kojii, 2016-05-24 09:49:14]

https://codereview.chromium.org/2002063003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.h (right):

https://codereview.chromium.org/2002063003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.h:217: enum CreateElementFlags {
On 2016/05/24 at 08:53:53, Yosi_UTC9 wrote:
> Is this bit flag? If not, please use |enum class| to allow forward
declaration?

Yes, this is a bit flag.

[yosin_UTC9, 2016-05-25 01:32:53]

https://codereview.chromium.org/2002063003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.h (right):

https://codereview.chromium.org/2002063003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.h:217: enum CreateElementFlags {
On 2016/05/24 at 09:49:14, kojii wrote:
> On 2016/05/24 at 08:53:53, Yosi_UTC9 wrote:
> > Is this bit flag? If not, please use |enum class| to allow forward
declaration?
> 
> Yes, this is a bit flag.

How about using |CreateRequester| or another good name to specify, parser,
createElement(), import, clone, etc? If so, we can close concept of sync/async
customer element creation in Customer Element module. It is hard to maintain or
review by remembering which one is sync/async.

The kludge we can use:

enum CreateRequester {
  ForSynchronousCustomElements = 1,
  ForAsynchronousCustomElements = 0,

  CreateByParser = SynchronousCustomElements,
  CreateByClone = AsynchronousCustomElements,
  CreateByImportNode = AsynchronousCustomElements,
  CreateByCreateElement = SynchronousCustomElements,
  ...
}

[kojii, 2016-05-25 04:11:45]

https://codereview.chromium.org/2002063003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.h (right):

https://codereview.chromium.org/2002063003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.h:217: enum CreateElementFlags {
On 2016/05/25 at 01:32:52, Yosi_UTC9 wrote:
> On 2016/05/24 at 09:49:14, kojii wrote:
> > On 2016/05/24 at 08:53:53, Yosi_UTC9 wrote:
> > > Is this bit flag? If not, please use |enum class| to allow forward
declaration?
> > 
> > Yes, this is a bit flag.
> 
> How about using |CreateRequester| or another good name to specify, parser,
createElement(), import, clone, etc? If so, we can close concept of sync/async
customer element creation in Customer Element module. It is hard to maintain or
review by remembering which one is sync/async.
> 
> The kludge we can use:
> 
> enum CreateRequester {
>   ForSynchronousCustomElements = 1,
>   ForAsynchronousCustomElements = 0,
> 
>   CreateByParser = SynchronousCustomElements,
>   CreateByClone = AsynchronousCustomElements,
>   CreateByImportNode = AsynchronousCustomElements,
>   CreateByCreateElement = SynchronousCustomElements,
>   ...
> }

Done, added aliases.

The sync flag is added to the spec, and whenever the spec "create an element",
it specifies its value, so I think it's useful to set/unset directly without
relying on the requester.

However, there are some parts we don't have specs (editing! ;) so serving both
cases is a good idea.

I didn't add ImportNode because both cloneNode() and importNode() refer to the
"clone a node" concept:
https://dom.spec.whatwg.org/#concept-node-clone

[kojii, 2016-05-25 04:19:41]

Patchset #3 (id:40001) has been deleted

[kojii, 2016-05-25 04:22:09]

Patchset #3 (id:60001) has been deleted

[yosin_UTC9, 2016-05-25 04:35:04]

On 2016/05/25 at 04:11:45, kojii wrote:
>
https://codereview.chromium.org/2002063003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/Document.h (right):
> 
>
https://codereview.chromium.org/2002063003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/Document.h:217: enum CreateElementFlags {
> On 2016/05/25 at 01:32:52, Yosi_UTC9 wrote:
> > On 2016/05/24 at 09:49:14, kojii wrote:
> > > On 2016/05/24 at 08:53:53, Yosi_UTC9 wrote:
> > > > Is this bit flag? If not, please use |enum class| to allow forward
declaration?
> > > 
> > > Yes, this is a bit flag.
> > 
> > How about using |CreateRequester| or another good name to specify, parser,
createElement(), import, clone, etc? If so, we can close concept of sync/async
customer element creation in Customer Element module. It is hard to maintain or
review by remembering which one is sync/async.
> > 
> > The kludge we can use:
> > 
> > enum CreateRequester {
> >   ForSynchronousCustomElements = 1,
> >   ForAsynchronousCustomElements = 0,
> > 
> >   CreateByParser = SynchronousCustomElements,
> >   CreateByClone = AsynchronousCustomElements,
> >   CreateByImportNode = AsynchronousCustomElements,
> >   CreateByCreateElement = SynchronousCustomElements,
> >   ...
> > }
> 
> Done, added aliases.
> 
> The sync flag is added to the spec, and whenever the spec "create an element",
it specifies its value, so I think it's useful to set/unset directly without
relying on the requester.
> 
> However, there are some parts we don't have specs (editing! ;) so serving both
cases is a good idea.
> 
> I didn't add ImportNode because both cloneNode() and importNode() refer to the
"clone a node" concept:
> https://dom.spec.whatwg.org/#concept-node-clone

Introducing enum field for "importNode" helps people who doesn't familiar with
customer element spec and make no surprise readers, e.g. readers should stop
createElement w/ creator cloneNode and think why importNode calls createElement
with creator == cloneNode.

[dominicc (has gone to gerrit), 2016-05-25 06:40:20]

lgtm

Splendid.

On whether to have a value for import node which aliases something, I can see it
both ways. On the one hand, adding a value for import node makes it easy to see
the call site is doing the right thing and the usual combinations of flags are
listed in one place at the enum; on the other hand, if the core DOM concept is
cloning matching the DOM concept makes the code-spec relationship clearer. I
leave it up to you.

[kojii, 2016-05-25 07:11:21]

On 2016/05/25 at 06:40:20, dominicc wrote:
> lgtm
> 
> Splendid.
> 
> On whether to have a value for import node which aliases something, I can see
it both ways. On the one hand, adding a value for import node makes it easy to
see the call site is doing the right thing and the usual combinations of flags
are listed in one place at the enum; on the other hand, if the core DOM concept
is cloning matching the DOM concept makes the code-spec relationship clearer. I
leave it up to you.

Thank you. Added ImportNode, I don't feel strongly either way too.

Will land after the other "hook" patch.

[kojii, 2016-05-26 03:35:22]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-05-26 03:35:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2002063003/#ps100001
(title: "Add ImportNode")

[commit-bot: I haz the power, 2016-05-26 03:35:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002063003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002063003/100001

[commit-bot: I haz the power, 2016-05-26 05:18:12]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-05-26 05:20:23]

Description was changed from

==========
Change "bool createdByParser" of createElement() to enum

The "create an element"[1] defines "synchronous custom elements flag"
that is set to false if:
1. To clone a node[2].
2. The parser was originally created for the HTML fragment parsing
   algorithm[3].

This patch changes "bool createdByParser" of createElement() to an enum
so that callers can pass this flag to "create an element"[1].

Using the "synchronous custom elements flag" is not implemented yet,
and thus no behavior changes.

[1] https://dom.spec.whatwg.org/#concept-create-element
[2] https://dom.spec.whatwg.org/#concept-node-clone
[3] https://html.spec.whatwg.org/#create-an-element-for-the-token

BUG=594918
==========

to

==========
Change "bool createdByParser" of createElement() to enum

The "create an element"[1] defines "synchronous custom elements flag"
that is set to false if:
1. To clone a node[2].
2. The parser was originally created for the HTML fragment parsing
   algorithm[3].

This patch changes "bool createdByParser" of createElement() to an enum
so that callers can pass this flag to "create an element"[1].

Using the "synchronous custom elements flag" is not implemented yet,
and thus no behavior changes.

[1] https://dom.spec.whatwg.org/#concept-create-element
[2] https://dom.spec.whatwg.org/#concept-node-clone
[3] https://html.spec.whatwg.org/#create-an-element-for-the-token

BUG=594918

Committed: https://crrev.com/7b0c4a78866841553fe991142d3a516c89f5f851
Cr-Commit-Position: refs/heads/master@{#396125}
==========

[commit-bot: I haz the power, 2016-05-26 05:20:24]

Patchset 4 (id:??) landed as
https://crrev.com/7b0c4a78866841553fe991142d3a516c89f5f851
Cr-Commit-Position: refs/heads/master@{#396125}