third_party/WebKit/Source/core/html/HTMLSelectElement.cpp - Issue 2002063003: Change "bool createdByParser" of createElement() to enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2002063003: Change "bool createdByParser" of createElement() to enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cestate

Patch Set: Add ImportNode Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/events/EventPathTest.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

index 8254a174992b257075ca6c8496c67d03e5300c9d..5b93b34e05e16eebdd6c55b5f7cd59b40a3e8087 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

@@ -503,7 +503,7 @@ void HTMLSelectElement::setLength(unsigned newLen, ExceptionState& exceptionStat

if (diff < 0) { // Add dummy elements.

do {

- appendChild(document().createElement(optionTag, false), exceptionState);

+ appendChild(document().createElement(optionTag, CreatedByCreateElement), exceptionState);

if (exceptionState.hadException())

break;

} while (++diff);