Change "bool createdByParser" of createElement() to enum

third_party/WebKit/Source/core/dom/Document.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
@@ skipping 196 matching lines @@
     SVGDocumentClass = 1 << 5,
     XMLDocumentClass = 1 << 6,
 };
 
 enum ShadowCascadeOrder {
     ShadowCascadeNone,
     ShadowCascadeV0,
     ShadowCascadeV1
 };
 
+enum CreateElementFlags {

[yosin_UTC9, 2016/05/24 08:53:53]

Is this bit flag? If not, please use |enum class| to allow forward declaration?

[kojii, 2016/05/24 09:49:14]

Yes, this is a bit flag.

[yosin_UTC9, 2016/05/25 01:32:52]

How about using |CreateRequester| or another good name to specify, parser,
createElement(), import, clone, etc? If so, we can close concept of sync/async
customer element creation in Customer Element module. It is hard to maintain or
review by remembering which one is sync/async.

The kludge we can use:

enum CreateRequester {
  ForSynchronousCustomElements = 1,
  ForAsynchronousCustomElements = 0,

  CreateByParser = SynchronousCustomElements,
  CreateByClone = AsynchronousCustomElements,
  CreateByImportNode = AsynchronousCustomElements,
  CreateByCreateElement = SynchronousCustomElements,
  ...
}

[kojii, 2016/05/25 04:11:45]

Done, added aliases.

The sync flag is added to the spec, and whenever the spec "create an element",
it specifies its value, so I think it's useful to set/unset directly without
relying on the requester.

However, there are some parts we don't have specs (editing! ;) so serving both
cases is a good idea.

I didn't add ImportNode because both cloneNode() and importNode() refer to the
"clone a node" concept:
https://dom.spec.whatwg.org/#concept-node-clone

+    CreatedByParser = 1 << 0,
+    // Synchronous custom elements flag
+    // https://dom.spec.whatwg.org/#concept-create-element
+    SynchronousCustomElements = 0,
+    AsynchronousCustomElements = 1 << 1,
+};
+
 using DocumentClassFlags = unsigned char;
 
 class CORE_EXPORT Document : public ContainerNode, public TreeScope, public SecurityContext, public ExecutionContext, public Supplementable<Document> {
     DEFINE_WRAPPERTYPEINFO();
     USING_GARBAGE_COLLECTED_MIXIN(Document);
 public:
     static Document* create(const DocumentInit& initializer = DocumentInit())
     {
         return new Document(initializer);
     }
@@ skipping 58 matching lines @@
     Element* createElement(const AtomicString& name, ExceptionState&);
     DocumentFragment* createDocumentFragment();
     Text* createTextNode(const String& data);
     Comment* createComment(const String& data);
     CDATASection* createCDATASection(const String& data, ExceptionState&);
     ProcessingInstruction* createProcessingInstruction(const String& target, const String& data, ExceptionState&);
     Attr* createAttribute(const AtomicString& name, ExceptionState&);
     Attr* createAttributeNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&, bool shouldIgnoreNamespaceChecks = false);
     Node* importNode(Node* importedNode, bool deep, ExceptionState&);
     Element* createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&);
-    Element* createElement(const QualifiedName&, bool createdByParser);
+    Element* createElement(const QualifiedName&, CreateElementFlags);
 
     Element* elementFromPoint(int x, int y) const;
     HeapVector<Member<Element>> elementsFromPoint(int x, int y) const;
     Range* caretRangeFromPoint(int x, int y);
     Element* scrollingElement();
     VisualViewport* visualViewport();
 
     String readyState() const;
 
     AtomicString characterSet() const { return Document::encodingName(); }
@@ skipping 1131 matching lines @@
 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true);
 
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 CORE_EXPORT void showLiveDocumentInstances();
 #endif
 
 #endif // Document_h