[heap] Pass a force_promotion flag to the evacuation routine in the scavenger.

[heap] Pass a force_promotion flag to the evacuation routine in the scavenger.

The {force_promotion} flag causes the scavenger to move an object to the
old generation instead of to the other semi-space. We use the flag to force
the promotion of objects which are referenced by code objects.

R=ulan@chromium.org

Committed: https://crrev.com/f2a7ba6449406d0b11a245aa1f5b4981265b6f20
Cr-Commit-Position: refs/heads/master@{#36443}

Committed: https://crrev.com/7d3f9f13615af1c44b28caa62ea7c3a0a0f24c60
Cr-Commit-Position: refs/heads/master@{#36462}

[ulan, 2016-05-23 11:18:38]

Looks good.

https://codereview.chromium.org/2002013002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2002013002/diff/1/src/heap/heap.h#newcode305
src/heap/heap.h:305: bool force_promotion);
Please make it an enum.

[ahaas, 2016-05-23 12:39:20]

On 2016/05/23 at 11:18:38, ulan wrote:
> Looks good.
> 
> https://codereview.chromium.org/2002013002/diff/1/src/heap/heap.h
> File src/heap/heap.h (right):
> 
> https://codereview.chromium.org/2002013002/diff/1/src/heap/heap.h#newcode305
> src/heap/heap.h:305: bool force_promotion);
> Please make it an enum.

Done.

[ulan, 2016-05-23 13:04:22]

LGTM

https://codereview.chromium.org/2002013002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2002013002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1679: this, reinterpret_cast<Address>(addr), FORCE_PROMOTION);
Please add a comment why we force promotion here.
We expect that objects referenced by code are long living.
If we do not force promotion then we need to clear old_to_new slots in dead code
objects after mark-compact.

https://codereview.chromium.org/2002013002/diff/20001/src/heap/scavenger.cc
File src/heap/scavenger.cc (right):

https://codereview.chromium.org/2002013002/diff/20001/src/heap/scavenger.cc#n...
src/heap/scavenger.cc:222: return;
if (promotion_mode == FORCE_PROMOTION) 
FatalProcessOutOfMemory("Scavenger: object promotion\n");

[ahaas, 2016-05-23 13:31:48]

https://codereview.chromium.org/2002013002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2002013002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1679: this, reinterpret_cast<Address>(addr), FORCE_PROMOTION);
On 2016/05/23 at 13:04:22, ulan wrote:
> Please add a comment why we force promotion here.
> We expect that objects referenced by code are long living.
> If we do not force promotion then we need to clear old_to_new slots in dead
code objects after mark-compact.

Done.

https://codereview.chromium.org/2002013002/diff/20001/src/heap/scavenger.cc
File src/heap/scavenger.cc (right):

https://codereview.chromium.org/2002013002/diff/20001/src/heap/scavenger.cc#n...
src/heap/scavenger.cc:222: return;
On 2016/05/23 at 13:04:22, ulan wrote:
> if (promotion_mode == FORCE_PROMOTION) 
> FatalProcessOutOfMemory("Scavenger: object promotion\n");

Done.

[ahaas, 2016-05-23 13:31:53]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-05-23 13:31:53]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2002013002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-23 13:32:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002013002/40001

[commit-bot: I haz the power, 2016-05-23 14:01:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-23 14:03:01]

Description was changed from

==========
[heap] Pass a force_promotion flag to the evacuation routine in the scavenger.

The {force_promotion} flag causes the scavenger to move an object to the
old generation instead of to the other semi-space. We use the flag to force
the promotion of objects which are referenced by code objects.

R=ulan@chromium.org
==========

to

==========
[heap] Pass a force_promotion flag to the evacuation routine in the scavenger.

The {force_promotion} flag causes the scavenger to move an object to the
old generation instead of to the other semi-space. We use the flag to force
the promotion of objects which are referenced by code objects.

R=ulan@chromium.org

Committed: https://crrev.com/f2a7ba6449406d0b11a245aa1f5b4981265b6f20
Cr-Commit-Position: refs/heads/master@{#36443}
==========

[commit-bot: I haz the power, 2016-05-23 14:03:02]

Patchset 3 (id:??) landed as
https://crrev.com/f2a7ba6449406d0b11a245aa1f5b4981265b6f20
Cr-Commit-Position: refs/heads/master@{#36443}

[Michael Lippautz, 2016-05-24 07:17:32]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2007563004/ by mlippautz@chromium.org.

The reason for reverting is: Need to revert JSArrayBuffer change. Please rebase
and reland..

[ahaas, 2016-05-24 07:38:14]

On 2016/05/24 at 07:17:32, mlippautz wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2007563004/ by mlippautz@chromium.org.
> 
> The reason for reverting is: Need to revert JSArrayBuffer change. Please
rebase and reland..

Rebase.

[Michael Lippautz, 2016-05-24 07:57:32]

On 2016/05/24 07:38:14, ahaas wrote:
> On 2016/05/24 at 07:17:32, mlippautz wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2007563004/ by mailto:mlippautz@chromium.org.
> > 
> > The reason for reverting is: Need to revert JSArrayBuffer change. Please
> rebase and reland..
> 
> Rebase.

lgtm

[ahaas, 2016-05-24 08:08:59]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-05-24 08:08:59]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2002013002/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-05-24 08:09:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002013002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002013002/60001

[commit-bot: I haz the power, 2016-05-24 08:11:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-24 08:13:53]

Description was changed from

==========
[heap] Pass a force_promotion flag to the evacuation routine in the scavenger.

The {force_promotion} flag causes the scavenger to move an object to the
old generation instead of to the other semi-space. We use the flag to force
the promotion of objects which are referenced by code objects.

R=ulan@chromium.org

Committed: https://crrev.com/f2a7ba6449406d0b11a245aa1f5b4981265b6f20
Cr-Commit-Position: refs/heads/master@{#36443}
==========

to

==========
[heap] Pass a force_promotion flag to the evacuation routine in the scavenger.

The {force_promotion} flag causes the scavenger to move an object to the
old generation instead of to the other semi-space. We use the flag to force
the promotion of objects which are referenced by code objects.

R=ulan@chromium.org

Committed: https://crrev.com/f2a7ba6449406d0b11a245aa1f5b4981265b6f20
Cr-Commit-Position: refs/heads/master@{#36443}

Committed: https://crrev.com/7d3f9f13615af1c44b28caa62ea7c3a0a0f24c60
Cr-Commit-Position: refs/heads/master@{#36462}
==========

[commit-bot: I haz the power, 2016-05-24 08:13:54]

Patchset 4 (id:??) landed as
https://crrev.com/7d3f9f13615af1c44b28caa62ea7c3a0a0f24c60
Cr-Commit-Position: refs/heads/master@{#36462}