Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
index be177e7dc18e2e6c7bcade6ea5224773ad740e20..3bbe64c16ad8b8c94e58b495a826e49c262be597 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
@@ -94,13 +94,13 @@ v8::Local<v8::Value> V8FunctionCall::callWithoutExceptionHandling()
if (!thisObject->Get(m_context, m_name).ToLocal(&value))
return v8::Local<v8::Value>();
- ASSERT(value->IsFunction());
+ DCHECK(value->IsFunction());
v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(value);
OwnPtr<v8::Local<v8::Value>[]> info = adoptArrayPtr(new v8::Local<v8::Value>[m_arguments.size()]);
for (size_t i = 0; i < m_arguments.size(); ++i) {
info[i] = m_arguments[i];
- ASSERT(!info[i].IsEmpty());
+ DCHECK(!info[i].IsEmpty());
}
v8::MicrotasksScope microtasksScope(m_context->GetIsolate(), v8::MicrotasksScope::kDoNotRunMicrotasks);
@@ -118,7 +118,7 @@ v8::Local<v8::Function> V8FunctionCall::function()
if (!thisObject->Get(m_context, m_name).ToLocal(&value))
return v8::Local<v8::Function>();
- ASSERT(value->IsFunction());
+ DCHECK(value->IsFunction());
return v8::Local<v8::Function>::Cast(value);
}

Powered by Google App Engine
This is Rietveld 408576698