extensions/common/manifest_handlers/kiosk_mode_info.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/kiosk_mode_info.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix various builds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/prohibited_technologies_handler.cc ('K') | « extensions/common/features/base_feature_provider.cc ('k') | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_handlers/kiosk_mode_info.cc

diff --git a/extensions/common/manifest_handlers/kiosk_mode_info.cc b/extensions/common/manifest_handlers/kiosk_mode_info.cc

index 2dd0f9b1844e8f022431338e1a3e6f01eab52033..8f7440cada1b41bca7762d590b993b71700342a1 100644

--- a/extensions/common/manifest_handlers/kiosk_mode_info.cc

+++ b/extensions/common/manifest_handlers/kiosk_mode_info.cc

@@ -114,7 +114,7 @@ bool KioskModeHandler::Parse(Extension* extension, base::string16* error) {

return false;

}

- for (const base::Value* value : *list) {

+ for (const auto& value : *list) {

std::unique_ptr<KioskSecondaryAppsType> app =

KioskSecondaryAppsType::FromValue(*value, error);

if (!app) {