Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: extensions/renderer/dispatcher.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/dispatcher.cc
diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc
index ab770ca4cacf170aa6d43859338bea7e45ac4d82..695e7f5a98088740828503fb1647e170b2e48ab3 100644
--- a/extensions/renderer/dispatcher.cc
+++ b/extensions/renderer/dispatcher.cc
@@ -175,9 +175,8 @@ void CallModuleMethod(const std::string& module_name,
content::V8ValueConverter::create());
std::vector<v8::Local<v8::Value>> arguments;
- for (base::ListValue::const_iterator it = args->begin(); it != args->end();
- ++it) {
- arguments.push_back(converter->ToV8Value(*it, context->v8_context()));
+ for (const auto& arg : *args) {
+ arguments.push_back(converter->ToV8Value(arg.get(), context->v8_context()));
}
context->module_system()->CallModuleMethod(

Powered by Google App Engine
This is Rietveld 408576698