Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: content/browser/android/java/gin_java_method_invocation_helper.h

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/java/gin_java_method_invocation_helper.h
diff --git a/content/browser/android/java/gin_java_method_invocation_helper.h b/content/browser/android/java/gin_java_method_invocation_helper.h
index b2c0992eaa4d17ef315f6bbe42d580cf6ae89a6f..6582ccfe6b17f792729fb6896af88f6682c003f1 100644
--- a/content/browser/android/java/gin_java_method_invocation_helper.h
+++ b/content/browser/android/java/gin_java_method_invocation_helper.h
@@ -73,12 +73,12 @@ class CONTENT_EXPORT GinJavaMethodInvocationHelper
~GinJavaMethodInvocationHelper();
void BuildObjectRefsFromListValue(DispatcherDelegate* dispatcher,
- const base::Value* list_value);
+ const base::Value& list_value);
void BuildObjectRefsFromDictionaryValue(DispatcherDelegate* dispatcher,
- const base::Value* dict_value);
+ const base::Value& dict_value);
bool AppendObjectRef(DispatcherDelegate* dispatcher,
- const base::Value* raw_value);
+ const base::Value& raw_value);
void InvokeMethod(jobject object,
jclass clazz,

Powered by Google App Engine
This is Rietveld 408576698