components/url_matcher/url_matcher_factory.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/url_matcher/url_matcher_factory.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix various builds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/prohibited_technologies_handler.cc ('K') | « components/update_client/component_patcher.cc ('k') | content/browser/android/java/gin_java_method_invocation_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/url_matcher/url_matcher_factory.cc

diff --git a/components/url_matcher/url_matcher_factory.cc b/components/url_matcher/url_matcher_factory.cc

index e7ce483cd025fe32fec90543d86b53a4dbad4509..848e5d469396040fed208f4664e97ca3ada2edd7 100644

--- a/components/url_matcher/url_matcher_factory.cc

+++ b/components/url_matcher/url_matcher_factory.cc

@@ -248,9 +248,7 @@ std::unique_ptr<URLMatcherPortFilter> URLMatcherFactory::CreateURLMatcherPorts(

return nullptr;

}

- for (base::ListValue::const_iterator i = value_list->begin();

- i != value_list->end(); ++i) {

- base::Value* entry = *i;

+ for (const auto& entry : *value_list) {

int port = 0;

base::ListValue* range = NULL;

if (entry->GetAsInteger(&port)) {