Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chromeos/system/statistics_provider.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/system/statistics_provider.cc
diff --git a/chromeos/system/statistics_provider.cc b/chromeos/system/statistics_provider.cc
index d5b49d0bf8b8a4495a53e98f1a03063e1896b877..4c8bf1fd79eee539012bab7003c507afe75fe586 100644
--- a/chromeos/system/statistics_provider.cc
+++ b/chromeos/system/statistics_provider.cc
@@ -93,7 +93,7 @@ bool JoinListValuesToString(const base::DictionaryValue* dictionary,
std::string buffer;
bool first = true;
- for (const base::Value* v : *list) {
+ for (const auto& v : *list) {
std::string value;
if (!v->GetAsString(&value))
return false;

Powered by Google App Engine
This is Rietveld 408576698