chromeos/network/shill_property_handler.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/shill_property_handler.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix various builds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/prohibited_technologies_handler.cc ('K') | « chromeos/network/prohibited_technologies_handler.cc ('k') | chromeos/system/statistics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/shill_property_handler.cc

diff --git a/chromeos/network/shill_property_handler.cc b/chromeos/network/shill_property_handler.cc

index a3f77a5419ca9135e4984466726e42a4331ee64f..a1e643f4d0046a175ddb7179f2232e264f626e31 100644

--- a/chromeos/network/shill_property_handler.cc

+++ b/chromeos/network/shill_property_handler.cc

@@ -379,7 +379,7 @@ void ShillPropertyHandler::UpdateObserved(ManagedState::ManagedType type,

(type == ManagedState::MANAGED_TYPE_NETWORK) ? observed_networks_

: observed_devices_;

ShillPropertyObserverMap new_observed;

- for (auto* entry : entries) {

+ for (const auto& entry : entries) {

std::string path;

entry->GetAsString(&path);

if (path.empty())