Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

chromeos/network/prohibited_technologies_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/prohibited_technologies_handler.h"
 
 #include "chromeos/network/managed_network_configuration_handler.h"
 #include "chromeos/network/network_state_handler.h"
 #include "chromeos/network/network_util.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
@@ skipping 45 matching lines @@
     return;
   user_policy_applied_ = true;
   EnforceProhibitedTechnologies();
 }
 
 void ProhibitedTechnologiesHandler::SetProhibitedTechnologies(
     const base::ListValue* prohibited_list) {
   // Build up prohibited network type list and save it for furthur use when
   // enforced
   prohibited_technologies_.clear();
-  for (const base::Value* item : *prohibited_list) {
+  for (const auto& item : *prohibited_list) {
     std::string prohibited_technology;
-    item->GetAsString(&prohibited_technology);
+    if (!item->GetAsString(&prohibited_technology))

[danakj, 2016/05/24 20:08:35]

nitto?

+      NOTREACHED();
     std::string translated_tech =
         network_util::TranslateONCTypeToShill(prohibited_technology);
     if (!translated_tech.empty())
       prohibited_technologies_.push_back(translated_tech);
   }
   EnforceProhibitedTechnologies();
 }
 
 void ProhibitedTechnologiesHandler::EnforceProhibitedTechnologies() {
   if (user_logged_in_ && user_policy_applied_) {
@@ skipping 24 matching lines @@
 }
 
 std::vector<std::string>
 ProhibitedTechnologiesHandler::GetCurrentlyProhibitedTechnologies() {
   if (user_logged_in_ && user_policy_applied_)
     return prohibited_technologies_;
   return std::vector<std::string>();
 }
 
 }  // namespace chromeos