Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 200063003: Remove enhanced bookmarks extension (Closed)

Created:
6 years, 9 months ago by Mike Wittman
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, dcheng, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove enhanced bookmarks extension Experimentation around bookmark styling in Chrome is being conducted in a separate extension, so this in-tree component extension is no longer needed. This reverts r226314. BUG=311282 R=estade@chromium.org, kalman@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3683 lines) Patch
M build/common.gypi View 4 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/component_loader.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 2 chunks +0 lines, -13 lines 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/css/bmm.css View 1 chunk +0 lines, -381 lines 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/css/bmm.css.js View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/images/2x/bookmark_manager_recent.png View Binary file 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/images/2x/bookmark_manager_search.png View Binary file 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/images/2x/bookmark_manager_search_rtl.png View Binary file 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/images/2x/bookmarks_section_32.png View Binary file 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/images/bookmark_manager_recent.png View Binary file 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/images/bookmark_manager_search.png View Binary file 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/images/bookmark_manager_search_rtl.png View Binary file 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/images/bookmarks_section_32.png View Binary file 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/js/bmm.js View 1 chunk +0 lines, -248 lines 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/js/bmm/bookmark_list.js View 1 chunk +0 lines, -566 lines 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/js/bmm/bookmark_tree.js View 1 chunk +0 lines, -307 lines 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/js/bmm_test.html View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/js/dnd.js View 1 chunk +0 lines, -502 lines 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/js/main.js View 1 chunk +0 lines, -1308 lines 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/main.html View 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/browser/resources/enhanced_bookmark_manager/manifest.json View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_url_handler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Mike Wittman
PTAL estade: everything kalman: chrome/{browser,common}/extensions sky: chrome/browser/browser_resources.grd, chrome/browser/ui/browser_navigator.cc
6 years, 9 months ago (2014-03-17 18:33:07 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-17 20:54:05 UTC) #2
Evan Stade
lgtm
6 years, 9 months ago (2014-03-17 20:56:55 UTC) #3
not at google - send to devlin
lgtm, apologies for delay
6 years, 9 months ago (2014-03-18 22:48:48 UTC) #4
Mike Wittman
The CQ bit was checked by wittman@chromium.org
6 years, 9 months ago (2014-03-18 22:51:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/200063003/1
6 years, 9 months ago (2014-03-18 22:52:24 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 22:59:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-18 22:59:11 UTC) #8
Mike Wittman
6 years, 9 months ago (2014-03-19 16:52:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r258008 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698