Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: chrome/browser/extensions/component_loader.cc

Issue 200063003: Remove enhanced bookmarks extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/component_loader.h" 5 #include "chrome/browser/extensions/component_loader.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 command_line->GetSwitchValuePath(switches::kImageLoaderExtensionPath)); 310 command_line->GetSwitchValuePath(switches::kImageLoaderExtensionPath));
311 Add(IDR_IMAGE_LOADER_MANIFEST, image_loader_extension_path); 311 Add(IDR_IMAGE_LOADER_MANIFEST, image_loader_extension_path);
312 return; 312 return;
313 } 313 }
314 #endif // NDEBUG 314 #endif // NDEBUG
315 Add(IDR_IMAGE_LOADER_MANIFEST, 315 Add(IDR_IMAGE_LOADER_MANIFEST,
316 base::FilePath(FILE_PATH_LITERAL("image_loader"))); 316 base::FilePath(FILE_PATH_LITERAL("image_loader")));
317 #endif // defined(IMAGE_LOADER_EXTENSION) 317 #endif // defined(IMAGE_LOADER_EXTENSION)
318 } 318 }
319 319
320 void ComponentLoader::AddBookmarksExtensions() {
321 Add(IDR_BOOKMARKS_MANIFEST,
322 base::FilePath(FILE_PATH_LITERAL("bookmark_manager")));
323 #if defined(ENABLE_ENHANCED_BOOKMARKS)
324 Add(IDR_ENHANCED_BOOKMARKS_MANIFEST,
325 base::FilePath(FILE_PATH_LITERAL("enhanced_bookmark_manager")));
326 #endif
327 }
328
329 void ComponentLoader::AddNetworkSpeechSynthesisExtension() { 320 void ComponentLoader::AddNetworkSpeechSynthesisExtension() {
330 Add(IDR_NETWORK_SPEECH_SYNTHESIS_MANIFEST, 321 Add(IDR_NETWORK_SPEECH_SYNTHESIS_MANIFEST,
331 base::FilePath(FILE_PATH_LITERAL("network_speech_synthesis"))); 322 base::FilePath(FILE_PATH_LITERAL("network_speech_synthesis")));
332 } 323 }
333 324
334 #if defined(OS_CHROMEOS) 325 #if defined(OS_CHROMEOS)
335 std::string ComponentLoader::AddChromeVoxExtension() { 326 std::string ComponentLoader::AddChromeVoxExtension() {
336 const CommandLine* command_line = CommandLine::ForCurrentProcess(); 327 const CommandLine* command_line = CommandLine::ForCurrentProcess();
337 int idr = command_line->HasSwitch(chromeos::switches::kGuestSession) ? 328 int idr = command_line->HasSwitch(chromeos::switches::kGuestSession) ?
338 IDR_CHROMEVOX_GUEST_MANIFEST : IDR_CHROMEVOX_MANIFEST; 329 IDR_CHROMEVOX_GUEST_MANIFEST : IDR_CHROMEVOX_MANIFEST;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
405 if (browser_defaults::enable_help_app) { 396 if (browser_defaults::enable_help_app) {
406 Add(IDR_HELP_MANIFEST, base::FilePath(FILE_PATH_LITERAL( 397 Add(IDR_HELP_MANIFEST, base::FilePath(FILE_PATH_LITERAL(
407 "/usr/share/chromeos-assets/helpapp"))); 398 "/usr/share/chromeos-assets/helpapp")));
408 } 399 }
409 #endif 400 #endif
410 401
411 // Skip all other extensions that require user session presence. 402 // Skip all other extensions that require user session presence.
412 if (!skip_session_components) { 403 if (!skip_session_components) {
413 const CommandLine* command_line = CommandLine::ForCurrentProcess(); 404 const CommandLine* command_line = CommandLine::ForCurrentProcess();
414 if (!command_line->HasSwitch(chromeos::switches::kGuestSession)) 405 if (!command_line->HasSwitch(chromeos::switches::kGuestSession))
415 AddBookmarksExtensions(); 406 Add(IDR_BOOKMARKS_MANIFEST,
407 base::FilePath(FILE_PATH_LITERAL("bookmark_manager")));
416 408
417 Add(IDR_CROSH_BUILTIN_MANIFEST, base::FilePath(FILE_PATH_LITERAL( 409 Add(IDR_CROSH_BUILTIN_MANIFEST, base::FilePath(FILE_PATH_LITERAL(
418 "/usr/share/chromeos-assets/crosh_builtin"))); 410 "/usr/share/chromeos-assets/crosh_builtin")));
419 } 411 }
420 #else // !defined(OS_CHROMEOS) 412 #else // !defined(OS_CHROMEOS)
421 DCHECK(!skip_session_components); 413 DCHECK(!skip_session_components);
422 AddBookmarksExtensions(); 414 Add(IDR_BOOKMARKS_MANIFEST,
415 base::FilePath(FILE_PATH_LITERAL("bookmark_manager")));
423 // Cloud Print component app. Not required on Chrome OS. 416 // Cloud Print component app. Not required on Chrome OS.
424 Add(IDR_CLOUDPRINT_MANIFEST, 417 Add(IDR_CLOUDPRINT_MANIFEST,
425 base::FilePath(FILE_PATH_LITERAL("cloud_print"))); 418 base::FilePath(FILE_PATH_LITERAL("cloud_print")));
426 #endif 419 #endif
427 420
428 if (!skip_session_components) { 421 if (!skip_session_components) {
429 AddWebStoreApp(); 422 AddWebStoreApp();
430 AddChromeApp(); 423 AddChromeApp();
431 } 424 }
432 425
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 off_the_record_context, Extension::GetBaseURLFromExtensionId(id)); 606 off_the_record_context, Extension::GetBaseURLFromExtensionId(id));
614 fileapi::FileSystemContext* file_system_context = 607 fileapi::FileSystemContext* file_system_context =
615 content::BrowserContext::GetStoragePartitionForSite( 608 content::BrowserContext::GetStoragePartitionForSite(
616 off_the_record_context, site)->GetFileSystemContext(); 609 off_the_record_context, site)->GetFileSystemContext();
617 file_system_context->EnableTemporaryFileSystemInIncognito(); 610 file_system_context->EnableTemporaryFileSystemInIncognito();
618 } 611 }
619 #endif 612 #endif
620 } 613 }
621 614
622 } // namespace extensions 615 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/component_loader.h ('k') | chrome/browser/resources/component_extension_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698