chrome/common/extensions/manifest_url_handler.cc - Issue 200063003: Remove enhanced bookmarks extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_url_handler.cc

Issue 200063003: Remove enhanced bookmarks extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/manifest_url_handler.cc

diff --git a/chrome/common/extensions/manifest_url_handler.cc b/chrome/common/extensions/manifest_url_handler.cc

index b1c1134575511c77d3a85d4cc5cf8199e6e73b36..08bed8b02c81c7d38f6051e845441c6b6ece8963 100644

--- a/chrome/common/extensions/manifest_url_handler.cc

+++ b/chrome/common/extensions/manifest_url_handler.cc

@@ -294,11 +294,6 @@ bool URLOverridesHandler::Parse(Extension* extension, base::string16* error) {

#if defined(OS_CHROMEOS)

is_override = (is_override && page != keyboard::kKeyboardWebUIHost);

#endif

-#if defined(ENABLE_ENHANCED_BOOKMARKS)

- is_override = (is_override &&

- !(extension->location() == Manifest::COMPONENT &&

- page == chrome::kChromeUIEnhancedBookmarksHost));

-#endif

if (is_override || !iter.value().GetAsString(&val)) {

*error = base::ASCIIToUTF16(errors::kInvalidChromeURLOverrides);