Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: tracing/tracing/metrics/system_health/efficiency_metric.html

Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/efficiency_metric.html
diff --git a/tracing/tracing/metrics/system_health/efficiency_metric.html b/tracing/tracing/metrics/system_health/efficiency_metric.html
index f8920f0b715e0b336e505480b1b7cd4fdb6629c0..6274def9412cf046b660eabe1c68724bb7003699 100644
--- a/tracing/tracing/metrics/system_health/efficiency_metric.html
+++ b/tracing/tracing/metrics/system_health/efficiency_metric.html
@@ -28,11 +28,6 @@ tr.exportTo('tr.metrics.sh', function() {
var options = {};
options.description = DESCRIPTION;
- var groupingKeys = {};
- groupingKeys.userExpectationStableId = ue.stableId;
- groupingKeys.userExpectationStageTitle = ue.stageTitle;
- groupingKeys.userExpectationInitiatorTitle = ue.initiatorTitle;
-
var score = undefined;
if ((ue.totalCpuMs === undefined) ||
@@ -57,9 +52,7 @@ tr.exportTo('tr.metrics.sh', function() {
scores.push(score);
values.addValue(new tr.v.NumericValue(
- model.canonicalUrl, 'efficiency',
- new tr.v.ScalarNumeric(UNIT, score),
- options, groupingKeys));
+ 'efficiency', new tr.v.ScalarNumeric(UNIT, score), options));
});
// Manually reduce scores.
@@ -67,16 +60,13 @@ tr.exportTo('tr.metrics.sh', function() {
var options = {};
options.description = DESCRIPTION;
- var groupingKeys = {};
var overallScore = tr.b.Statistics.weightedMean(
scores, tr.metrics.sh.perceptualBlend);
if (overallScore === undefined)
return;
values.addValue(new tr.v.NumericValue(
- model.canonicalUrl, 'efficiency',
- new tr.v.ScalarNumeric(UNIT, overallScore),
- options, groupingKeys));
+ 'efficiency', new tr.v.ScalarNumeric(UNIT, overallScore), options));
}
tr.metrics.MetricRegistry.register(efficiencyMetric);
« no previous file with comments | « tracing/tracing/metrics/sample_metric.html ('k') | tracing/tracing/metrics/system_health/first_paint_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698