tracing/tracing/metrics/sample_metric.html - Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/sample_metric.html

Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/metrics/metric_registry_test.html ('k') | tracing/tracing/metrics/system_health/efficiency_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/metrics/sample_metric.html

diff --git a/tracing/tracing/metrics/sample_metric.html b/tracing/tracing/metrics/sample_metric.html

index 9fdaa3298d19c1f5c749a9c67ad1fb9c44a29d30..43ae5dae567dc833ef58bede398ba61fd27f942d 100644

--- a/tracing/tracing/metrics/sample_metric.html

+++ b/tracing/tracing/metrics/sample_metric.html

@@ -24,9 +24,9 @@ tr.exportTo('tr.metrics', function() {

var n2 = new tr.v.ScalarNumeric(sizeInBytes_smallerIsBetter, 2);

var n3 = SIZE_NUMERIC_BUILDER.build();

n3.add(1);

- values.addValue(new tr.v.NumericValue(model.canonicalUrl, 'foo', n1));

- values.addValue(new tr.v.NumericValue(model.canonicalUrl, 'bar', n2));

- values.addValue(new tr.v.NumericValue(model.canonicalUrl, 'baz', n3));

+ values.addValue(new tr.v.NumericValue('foo', n1));

+ values.addValue(new tr.v.NumericValue('bar', n2));

+ values.addValue(new tr.v.NumericValue('baz', n3));

}

tr.metrics.MetricRegistry.register(sampleMetric);

« no previous file with comments | « tracing/tracing/metrics/metric_registry_test.html ('k') | tracing/tracing/metrics/system_health/efficiency_metric.html » ('j') | no next file with comments »