tracing/tracing/metrics/system_health/first_paint_metric.html - Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/first_paint_metric.html

Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/metrics/system_health/efficiency_metric.html ('k') | tracing/tracing/metrics/system_health/hazard_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/metrics/system_health/first_paint_metric.html

diff --git a/tracing/tracing/metrics/system_health/first_paint_metric.html b/tracing/tracing/metrics/system_health/first_paint_metric.html

index e9958f7fecd6c602fc6ec5a2d44da4f992c8992d..8b1bfd17dcb177814e0821828de83bebe7642db6 100644

--- a/tracing/tracing/metrics/system_health/first_paint_metric.html

+++ b/tracing/tracing/metrics/system_health/first_paint_metric.html

@@ -200,7 +200,7 @@ tr.exportTo('tr.metrics.sh', function() {

histogram.add(timeToEvent, {url: url});

}, this);

values.addValue(new tr.v.NumericValue(

- model.canonicalUrl, metric.valueName, histogram,

+ metric.valueName, histogram,

{ description: metric.description }));

}, this);

}