xfa/fxbarcode/oned/BC_OnedCode128Reader.cpp - Issue 1998873002: Clean up XFA code which causes warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/oned/BC_OnedCode128Reader.cpp

Issue 1998873002: Clean up XFA code which causes warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/oned/BC_OnedCode128Reader.cpp

diff --git a/xfa/fxbarcode/oned/BC_OnedCode128Reader.cpp b/xfa/fxbarcode/oned/BC_OnedCode128Reader.cpp

index b5f5aa5fe475155715b9bcf8c7bec8d96c77a06f..a0479e7f6daf25e3b7c2eb9205ab6e4598bd99db 100644

--- a/xfa/fxbarcode/oned/BC_OnedCode128Reader.cpp

+++ b/xfa/fxbarcode/oned/BC_OnedCode128Reader.cpp

@@ -150,10 +150,8 @@ int32_t CBC_OnedCode128Reader::DecodeCode(CBC_CommonBitArray* row,

}

if (bestMatch >= 0) {

return bestMatch;

- } else {

- e = BCExceptionNotFound;

- return 0;

}

+ e = BCExceptionNotFound;

return 0;

}

CFX_ByteString CBC_OnedCode128Reader::DecodeRow(int32_t rowNumber,

« no previous file with comments | « xfa/fxbarcode/oned/BC_OneDimReader.cpp ('k') | xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp » ('j') | no next file with comments »