xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp - Issue 1998873002: Clean up XFA code which causes warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp

Issue 1998873002: Clean up XFA code which causes warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp

diff --git a/xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp b/xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp

index 5806b3d09da3274b1ab367f3a21252827701c038..bc9b14f04e2e989da67c3e384d615be25522f814 100644

--- a/xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp

+++ b/xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp

@@ -45,10 +45,7 @@ FX_BOOL CBC_OnedCode128Writer::CheckContentValidity(

if (m_codeFormat == BC_CODE128_B || m_codeFormat == BC_CODE128_C) {

while (position < contents.GetLength()) {

patternIndex = (int32_t)contents.GetAt(position);

- if (patternIndex >= 32 && patternIndex <= 126 && patternIndex != 34) {

- position++;

- continue;

- } else {

+ if (patternIndex < 32 || patternIndex > 126 || patternIndex == 34) {

ret = FALSE;

break;

}