xfa/fxbarcode/oned/BC_OneDimReader.cpp - Issue 1998873002: Clean up XFA code which causes warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/oned/BC_OneDimReader.cpp

Issue 1998873002: Clean up XFA code which causes warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/oned/BC_OneDimReader.cpp

diff --git a/xfa/fxbarcode/oned/BC_OneDimReader.cpp b/xfa/fxbarcode/oned/BC_OneDimReader.cpp

index 5187c34af94ae57b471246b15bda550e7c1e7b69..a1cfc9b492fabb1f776c5a6dfc20f53960dce481 100644

--- a/xfa/fxbarcode/oned/BC_OneDimReader.cpp

+++ b/xfa/fxbarcode/oned/BC_OneDimReader.cpp

@@ -211,9 +211,7 @@ int32_t CBC_OneDimReader::DecodeDigit(CBC_CommonBitArray* row,

}

if (bestMatch >= 0) {

return bestMatch;

- } else {

- e = BCExceptionNotFound;

- return 0;

}

+ e = BCExceptionNotFound;

return 0;

}