Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 1998353003: Reduce ConsoleMessage API surface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1999463002
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
index a6fdcfaae80dc88b05840a870b045fbdf6fa0fdb..c3d73aa8a0e419fb9614ac219e111c7f74db47fc 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
@@ -207,10 +207,7 @@ void ThreadDebugger::logCallback(const v8::FunctionCallbackInfo<v8::Value>& info
ScriptValue(scriptState, info[0])
});
- ConsoleMessage* consoleMessage = ConsoleMessage::create(ConsoleAPIMessageSource, LogMessageLevel, event->type());
- consoleMessage->setType(LogMessageType);
- consoleMessage->setScriptState(scriptState);
- consoleMessage->setScriptArguments(ScriptArguments::create(scriptState, arguments));
+ ConsoleMessage* consoleMessage = ConsoleMessage::createForConsoleAPI(LogMessageLevel, LogMessageType, event->type(), ScriptArguments::create(scriptState, arguments));
debugger->reportMessageToConsole(context, consoleMessage);
}
@@ -345,12 +342,7 @@ void ThreadDebugger::reportMessageToConsole(v8::Local<v8::Context> context, Mess
if (messageText.isEmpty() && scriptArguments)
scriptArguments->getFirstArgumentAsString(messageText);
- ConsoleMessage* consoleMessage = ConsoleMessage::create(ConsoleAPIMessageSource, level, messageText);
- consoleMessage->setType(type);
- consoleMessage->setScriptState(scriptState);
- if (arguments)
- consoleMessage->setScriptArguments(scriptArguments);
- reportMessageToConsole(context, consoleMessage);
+ reportMessageToConsole(context, ConsoleMessage::createForConsoleAPI(level, type, messageText, scriptArguments));
}
void ThreadDebugger::consoleTime(const String16& title)

Powered by Google App Engine
This is Rietveld 408576698