third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp - Issue 1998353003: Reduce ConsoleMessage API surface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

Issue 1998353003: Reduce ConsoleMessage API surface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1999463002

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

index f4edaad193027ec3b0f7b70a0abfc8536a123cc6..8975ecc6f4be37a0c2312b12119b89559684d987 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

@@ -708,8 +708,7 @@ void InspectorResourceAgent::didFinishXHRInternal(ExecutionContext* context, XML

if (m_state->booleanProperty(ResourceAgentState::monitoringXHR, false)) {

String message = (success ? "XHR finished loading: " : "XHR failed loading: ") + method + " \"" + url + "\".";

- ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource, DebugMessageLevel, message);

- consoleMessage->setRequestIdentifier(it->value);

+ ConsoleMessage* consoleMessage = ConsoleMessage::createForRequest(NetworkMessageSource, DebugMessageLevel, message, url, it->value);

m_inspectedFrames->root()->host()->consoleMessageStorage().reportMessage(context, consoleMessage);

}

m_knownRequestIdMap.remove(client);

@@ -735,8 +734,7 @@ void InspectorResourceAgent::didFinishFetch(ExecutionContext* context, Threadabl