Issue 1998263002: Include multiplication in the megamorphic cache hash to avoid cid ranges overlapping modulo table s…

Issue 1998263002: Include multiplication in the megamorphic cache hash to avoid cid ranges overlapping modulo table s… (Closed)

Created:
4 years, 7 months ago by rmacnak

Modified:
4 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Include multiplication in the megamorphic cache hash to avoid cid ranges overlapping modulo table size from causing large displacements. CompileOnceHelloHtml +7.115% x64 Dart2JSCompileAll +1.363% x64 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/4d48c341bf79731cb60420ed51abc53a2b4d38fa

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -5 lines)			Patch
M	runtime/vm/object.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

rmacnak

4 years, 7 months ago (2016-05-20 17:41:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4d48c341bf79731cb60420ed51abc53a2b4d38fa (presubmit successful).